From: Mark Brown <broonie@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Doug Anderson <dianders@chromium.org>,
Chunyan Zhang <zhang.chunyan@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
ckeepax@opensource.cirrus.com,
LKML <linux-kernel@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage
Date: Wed, 9 Oct 2019 10:54:18 +0100 [thread overview]
Message-ID: <20191009095418.GA3929@sirena.co.uk> (raw)
In-Reply-To: <20191008201622.b7ev4nfyhqapspon@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
On Tue, Oct 08, 2019 at 10:16:22PM +0200, Marco Felsch wrote:
> On 19-10-08 17:23, Mark Brown wrote:
> > As you'll have seen from the discussion that's a bug, nothing should be
> > taking a reference to the regulator outside of explicit enable calls.
> Okay now we are on the right way :) Is the solution proposed by Doug:
> ".. we need to match "regulator->enable_count" to "rdev->use_count" at
> the end of _regulator_get() in the exclusive case..." the correct fix?
Yes, I think so.
> Another question. Please can you have a look on the "DA9062 PMIC fixes
> and features" series as well?
I don't know what that is, sorry.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-09 9:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 15:40 [PATCH 0/3] Regulator core fixes Marco Felsch
2019-09-17 15:40 ` [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage Marco Felsch
2019-09-23 18:02 ` Doug Anderson
2019-09-23 18:14 ` Mark Brown
2019-09-23 18:36 ` Doug Anderson
2019-09-23 18:49 ` Mark Brown
2019-09-23 22:40 ` Doug Anderson
2019-09-24 18:27 ` Mark Brown
2019-09-26 19:44 ` Doug Anderson
2019-09-27 8:47 ` Marco Felsch
2019-10-01 19:57 ` Doug Anderson
2019-10-04 6:34 ` Matti Vaittinen
2019-10-04 11:32 ` Mark Brown
2019-10-04 12:03 ` Vaittinen, Matti
2019-10-04 15:01 ` Mark Brown
2019-10-07 9:34 ` Marco Felsch
2019-10-07 18:29 ` Mark Brown
2019-10-08 6:03 ` Marco Felsch
2019-10-08 12:51 ` Mark Brown
2019-10-08 14:56 ` Marco Felsch
2019-10-08 15:42 ` Mark Brown
2019-10-08 16:16 ` Marco Felsch
2019-10-08 16:23 ` Mark Brown
2019-10-08 20:16 ` Marco Felsch
2019-10-09 9:54 ` Mark Brown [this message]
2019-09-17 15:40 ` [PATCH 2/3] regulator: of: fix suspend-min/max-voltage parsing Marco Felsch
2019-09-17 16:02 ` Applied "regulator: of: fix suspend-min/max-voltage parsing" to the regulator tree Mark Brown
2019-09-17 15:40 ` [PATCH 3/3] regulator: core: make regulator_register() EPROBE_DEFER aware Marco Felsch
2019-09-17 16:02 ` Applied "regulator: core: make regulator_register() EPROBE_DEFER aware" to the regulator tree Mark Brown
2019-09-18 0:57 ` [PATCH 3/3] regulator: core: make regulator_register() EPROBE_DEFER aware Dmitry Torokhov
2019-09-18 8:18 ` Marco Felsch
2019-09-18 15:53 ` Dmitry Torokhov
2019-09-18 16:06 ` Marco Felsch
2019-09-18 16:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009095418.GA3929@sirena.co.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=dianders@chromium.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).