From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE58C47404 for ; Wed, 9 Oct 2019 11:22:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24E9D21835 for ; Wed, 9 Oct 2019 11:22:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AQnXcr5a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730822AbfJILWd (ORCPT ); Wed, 9 Oct 2019 07:22:33 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53922 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727657AbfJILWc (ORCPT ); Wed, 9 Oct 2019 07:22:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570620151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fSxt4vlw0RrCjrUOMeZ4WTD/1koGsyolXMub27Mf3ik=; b=AQnXcr5a8aL/YagCSA2qprzTtotFsBMDUsQlivdb9IkE2iKvJSq++xnuYZDZbPe1MB0j5P QGQfcb+Z2MbkraUVpwrrEmD6lOuZTD5culnfGOyYsXO1IhRAP8HExldKocCd/o7sNPcyYT FDlZA6MysfebozT5VQRP65M0vK3gfho= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-363-Y66rTtV-Mx-6IQa7PTDtkQ-1; Wed, 09 Oct 2019 07:22:29 -0400 Received: by mail-wr1-f69.google.com with SMTP id y18so968727wrw.8 for ; Wed, 09 Oct 2019 04:22:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Eew1CqsB5Kurpo7mgW6HjC4gIkz4FQUu+JSkbHqlln8=; b=rNFrZ917XSOUIwxQtLVuwJzVNSJa/qNST7JyDKE0c3YfYqZiE0ulzPMgbtWxOIiibg yqSBFAM1gtMOWtPo5xCeHDq1iEntgVZodcW5/OeTLlK2z4qSKRFidK5NohxkXPnpw67n n+5OXIgKnTqCO7vYeVphCdBHRuf1GqBZX88LHep4VEwrBRN+poFdSlEabAZhe0zuVAye iAHD2YSuGDoAetCG5DxdOFuQ4nvZ31nQ6ijPjnOXqMZhtbiUujsEejrc5TASvdFrFgoR ZJ7pn9YBYf+kO5jqaLbHMBCA0bIAjrs2yY2v0G7SGJ71kYRH/ykmGLlGb1JdKKL2aTVm rYjw== X-Gm-Message-State: APjAAAVs34GD6NWjMpdgeE+18mxaSAMIEHPosxB5LW4XBfKpVysTnUhM RS45O8P2ELiqYSd8Iy25fb9hrwYCF+hA6bmTrGkhea2QQ1iOPP9kBRURs8w+vkSbCgdIHqvh8QZ KF+EnlKHiDDrwXgxwCO1cjvry X-Received: by 2002:a5d:670b:: with SMTP id o11mr134151wru.31.1570620148243; Wed, 09 Oct 2019 04:22:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqzyDH2yB45oDJuaeMzYuAzPHkv+uoWcEOBdzCqvL0hQ3GLQFyhYxwGywmUes44prwkkxN0yjw== X-Received: by 2002:a5d:670b:: with SMTP id o11mr134132wru.31.1570620148012; Wed, 09 Oct 2019 04:22:28 -0700 (PDT) Received: from localhost (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id n7sm1839941wrt.59.2019.10.09.04.22.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 04:22:27 -0700 (PDT) Date: Wed, 9 Oct 2019 13:22:25 +0200 From: Oleksandr Natalenko To: linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, Jonathan Corbet , Mauro Carvalho Chehab , Vasily Gorbik , Ingo Molnar , Heiko Carstens , Thorsten Leemhuis , Quentin Perret Subject: Re: [PATCH] docs: admin-guide: fix printk_ratelimit explanation Message-ID: <20191009112225.tspuot7sstybqeud@butterfly.localdomain> References: <20191002114610.5773-1-oleksandr@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191002114610.5773-1-oleksandr@redhat.com> User-Agent: NeoMutt/20180716 X-MC-Unique: Y66rTtV-Mx-6IQa7PTDtkQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. On Wed, Oct 02, 2019 at 01:46:10PM +0200, Oleksandr Natalenko wrote: > The printk_ratelimit value accepts seconds, not jiffies (though it is > converted into jiffies internally). Update documentation to reflect > this. >=20 > Also, remove the statement about allowing 1 message in 5 seconds since > bursts up to 10 messages are allowed by default. >=20 > Finally, while we are here, mention default value for > printk_ratelimit_burst too. >=20 > Signed-off-by: Oleksandr Natalenko > --- > Documentation/admin-guide/sysctl/kernel.rst | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/= admin-guide/sysctl/kernel.rst > index 032c7cd3cede..6e0da29e55f1 100644 > --- a/Documentation/admin-guide/sysctl/kernel.rst > +++ b/Documentation/admin-guide/sysctl/kernel.rst > @@ -831,8 +831,8 @@ printk_ratelimit: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =20 > Some warning messages are rate limited. printk_ratelimit specifies > -the minimum length of time between these messages (in jiffies), by > -default we allow one every 5 seconds. > +the minimum length of time between these messages (in seconds). > +The default value is 5 seconds. > =20 > A value of 0 will disable rate limiting. > =20 > @@ -845,6 +845,8 @@ seconds, we do allow a burst of messages to pass thro= ugh. > printk_ratelimit_burst specifies the number of messages we can > send before ratelimiting kicks in. > =20 > +The default value is 10 messages. > + > =20 > printk_devkmsg: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --=20 > 2.23.0 >=20 This is a gentle ping. Please review. Thanks. --=20 Best regards, Oleksandr Natalenko (post-factum) Senior Software Maintenance Engineer