From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB663ECE58D for ; Wed, 9 Oct 2019 14:41:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92AA7206B6 for ; Wed, 9 Oct 2019 14:41:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ob7G1xVz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731565AbfJIOle (ORCPT ); Wed, 9 Oct 2019 10:41:34 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:36324 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731400AbfJIOld (ORCPT ); Wed, 9 Oct 2019 10:41:33 -0400 Received: by mail-wm1-f66.google.com with SMTP id m18so2917083wmc.1 for ; Wed, 09 Oct 2019 07:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kj8kcZrV2Ie6KvU8hO/1zbuJDnDpMortIjA2JmRJQi8=; b=ob7G1xVzMMoZbuszEsmDW7+f8TTVwcOkmedylA9Vwn+H+9MHBJX8omWH6PmCV5OMv+ 4gXH8xWhlBx4+hjOEkH/VERbpgqEWrbpmpjpaceLslclzFmNaSZSlRzr8stf5Mw9fcQR n6JVm0W5UDpiIpuMIO8MV2in1Dk5eAOY1i7+yukIWbyQWrCWeE9fwHo7za9vbWXCWJBp tjQi+IZgLN+DzJK9WFtg6Yj3xQH2Q9d9T4ICHjQxM/tAKSfax1iODY1gzqedo155bJLb SHdy1z/h7iT21ltciliox9lL8hTM779v+jbMobvwH1cCvFjZRvTN7lMgoaltO82Rf4jS ZyNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kj8kcZrV2Ie6KvU8hO/1zbuJDnDpMortIjA2JmRJQi8=; b=jFxtvyekBrmbCsdcEmoNn3V63j7SfY8xrdQvDPDN+g9CDpo9BhlThuF3dnWtdziXwa u4GtMi+s35Y5mP5+OHx8awlcfNo7g8baiBsh5zmZl62w+cTPTnpskaeN1oQo3IDtq9XT 8HGsLBnrcpFFTiGcU0t7ANpiLWxO9CucSgczpFSdYRYB7o1Eb1AsBY2XqYZExHs8ZtmU SC/ezyVzSVsiXMHEfOGdkbW4AtxYUjM6I/b42eFev7YJ1co4eeLv5CM9uYhZwyWFwe5U rF+4L2Uyjd1SYWejlaMaMXS8naoSIN11KTU/YtuoETNr7TV46E1opvhRwrzlovggQ8cO LVOQ== X-Gm-Message-State: APjAAAWhn7zetEkyzedmPPhdwPo8i3srzI/LNZw0QmGGub6iscpxydwk /RsQL8C2k7V+ANb1Az/1fiJF/w== X-Google-Smtp-Source: APXvYqzD6hQg63tJmuj8nmWSze/iS9hgaRn3cdPRFnzr1Lb4XjJzHI7vsIdMl2lCy06c4oKevANYeQ== X-Received: by 2002:a1c:1bd8:: with SMTP id b207mr2874814wmb.62.1570632092078; Wed, 09 Oct 2019 07:41:32 -0700 (PDT) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id b7sm3031770wrx.56.2019.10.09.07.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 07:41:31 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla , Bjorn Andersson Subject: [PATCH v3 2/5] misc: fastrpc: fix memory leak from miscdev->name Date: Wed, 9 Oct 2019 15:41:20 +0100 Message-Id: <20191009144123.24583-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191009144123.24583-1-srinivas.kandagatla@linaro.org> References: <20191009144123.24583-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix a memory leak in miscdev->name by using devm_variant Orignally reported by kmemleak: [] kmemleak_alloc+0x50/0x84 [] __kmalloc_track_caller+0xe8/0x168 [] kvasprintf+0x78/0x100 [] kasprintf+0x50/0x74 [] fastrpc_rpmsg_probe+0xd8/0x20c [] rpmsg_dev_probe+0xa8/0x148 [] really_probe+0x208/0x248 [] driver_probe_device+0x98/0xc0 [] __device_attach_driver+0x9c/0xac [] bus_for_each_drv+0x60/0x8c [] __device_attach+0x8c/0x100 [] device_initial_probe+0x20/0x28 [] bus_probe_device+0x34/0x7c [] device_add+0x420/0x498 [] device_register+0x24/0x2c Signed-off-by: Srinivas Kandagatla Reviewed-by: Bjorn Andersson --- drivers/misc/fastrpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index aa1249bb581a..c0fe3419c685 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -1610,8 +1610,8 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) return -ENOMEM; data->miscdev.minor = MISC_DYNAMIC_MINOR; - data->miscdev.name = kasprintf(GFP_KERNEL, "fastrpc-%s", - domains[domain_id]); + data->miscdev.name = devm_kasprintf(rdev, GFP_KERNEL, "fastrpc-%s", + domains[domain_id]); data->miscdev.fops = &fastrpc_fops; err = misc_register(&data->miscdev); if (err) -- 2.21.0