From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BAEBECE58C for ; Wed, 9 Oct 2019 17:03:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F39AE20B7C for ; Wed, 9 Oct 2019 17:02:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X5EfiGl+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731872AbfJIRC6 (ORCPT ); Wed, 9 Oct 2019 13:02:58 -0400 Received: from mail-yw1-f67.google.com ([209.85.161.67]:34563 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730546AbfJIRC6 (ORCPT ); Wed, 9 Oct 2019 13:02:58 -0400 Received: by mail-yw1-f67.google.com with SMTP id d192so1085322ywa.1; Wed, 09 Oct 2019 10:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dnZL99JTjxlFGbIIkPg5NnyiKXKoXT11Svd0yN/CwU8=; b=X5EfiGl+x8wyhlFGWbMvw90DM6DDHhDPF/5gPzPNCRnzrFO0yt9/jWjlnH2Iy5gy+a 9QmS6vt+ZLtP8PzRhnHnZ8zpoOgsnOv6KDKOjgKBDIXEwwtZ6/DOPwMeD6jH8yZOzRhF BGH4SIWcOfCasEWCrlm3EQd402/8oVJs/5MB4CD9LNj6prg6MqLUHhRDO1s2NXTi5kzu E9T6OVmiKiNgRgbvmNQJ2oA2/smIEAUON0UvuNe1E9xSXJxpVGcDXKVV8Ih4Sg99/n5b gX1/RKF0jXJr1Q6PV2OIG/ZZeo+8gPimesWSB13HQRg9OXNr7y/+5Yv5iVJwjp+kBOw0 a3XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dnZL99JTjxlFGbIIkPg5NnyiKXKoXT11Svd0yN/CwU8=; b=Z/hVulZYqojhfTLo5BEZQ5nBTOH65AVdbVBmb5l+JSslZCfabkf7aFPe6GbYspSl1A 9hB/QRWjd9TQfoVxhBY3vGl6hzIdN4zlYFY0OijZ3sbLS46VNQ5t502evpDx4+1ozp8z jUyVbLr9KBoR+pjqAEzTlW99FsGwvYHMktMD1r/4f4u4BWqT4X97YhyVGCKvN+Xom2sU jjRjksJVOwLm7EQ+C67NErRKHtJcpDqyLH5oCt4pEhHlXBl5pFm0+WMwBTAynAw6vTdr 6AzsbLPfVqAuK8ShhF9q4eF20X9sZw2ASflEDX/JxRMhQa2k2klpqAQVTAoJde9xoDXK bwOA== X-Gm-Message-State: APjAAAVMSqYW21FCsMOOaYz4X/JLNE4ULc2dL2+oYZr9m7FbUHuGdkxl GWW88sMtFIEOi83BsXDGFRA= X-Google-Smtp-Source: APXvYqx2fVc37Jf8721/9k+odhIVUj6R9YZYy9mgpcFhtXL3ap9OvdV7k7YmGOGXRyU68K5foqvdxg== X-Received: by 2002:a81:b607:: with SMTP id u7mr3541174ywh.77.1570640576499; Wed, 09 Oct 2019 10:02:56 -0700 (PDT) Received: from icarus (072-189-084-142.res.spectrum.com. [72.189.84.142]) by smtp.gmail.com with ESMTPSA id v8sm698871ywg.91.2019.10.09.10.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 10:02:55 -0700 (PDT) Date: Wed, 9 Oct 2019 13:02:40 -0400 From: William Breathitt Gray To: Masahiro Yamada Cc: Linus Walleij , Bartosz Golaszewski , Andrew Morton , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , linux-arch , Andy Shevchenko , Rasmus Villemoes , linux-arm-kernel , Linux PM mailing list , Geert Uytterhoeven , preid@electromag.com.au, Lukas Wunner , sean.nyekjaer@prevas.dk, morten.tiljeset@prevas.dk, Andy Shevchenko , Arnd Bergmann Subject: Re: [PATCH v17 01/14] bitops: Introduce the for_each_set_clump8 macro Message-ID: <20191009170240.GA93820@icarus> References: <893c3b4f03266c9496137cc98ac2b1bd27f92c73.1570633189.git.vilhelm.gray@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 10, 2019 at 01:28:08AM +0900, Masahiro Yamada wrote: > On Thu, Oct 10, 2019 at 12:27 AM William Breathitt Gray > wrote: > > > > This macro iterates for each 8-bit group of bits (clump) with set bits, > > within a bitmap memory region. For each iteration, "start" is set to the > > bit offset of the found clump, while the respective clump value is > > stored to the location pointed by "clump". Additionally, the > > bitmap_get_value8 and bitmap_set_value8 functions are introduced to > > respectively get and set an 8-bit value in a bitmap memory region. > > > > Suggested-by: Andy Shevchenko > > Suggested-by: Rasmus Villemoes > > Suggested-by: Lukas Wunner > > Cc: Arnd Bergmann > > Cc: Andrew Morton > > Cc: Andy Shevchenko > > Cc: Linus Walleij > > Signed-off-by: William Breathitt Gray > > --- > > include/asm-generic/bitops/find.h | 17 +++++++++++++++ > > include/linux/bitmap.h | 35 +++++++++++++++++++++++++++++++ > > include/linux/bitops.h | 5 +++++ > > lib/find_bit.c | 14 +++++++++++++ > > 4 files changed, 71 insertions(+) > > > > diff --git a/include/asm-generic/bitops/find.h b/include/asm-generic/bitops/find.h > > index 8a1ee10014de..9fdf21302fdf 100644 > > --- a/include/asm-generic/bitops/find.h > > +++ b/include/asm-generic/bitops/find.h > > @@ -80,4 +80,21 @@ extern unsigned long find_first_zero_bit(const unsigned long *addr, > > > > #endif /* CONFIG_GENERIC_FIND_FIRST_BIT */ > > > > +/** > > + * find_next_clump8 - find next 8-bit clump with set bits in a memory region > > + * @clump: location to store copy of found clump > > + * @addr: address to base the search on > > + * @size: bitmap size in number of bits > > + * @offset: bit offset at which to start searching > > + * > > + * Returns the bit offset for the next set clump; the found clump value is > > + * copied to the location pointed by @clump. If no bits are set, returns @size. > > + */ > > +extern unsigned long find_next_clump8(unsigned long *clump, > > + const unsigned long *addr, > > + unsigned long size, unsigned long offset); > > + > > +#define find_first_clump8(clump, bits, size) \ > > + find_next_clump8((clump), (bits), (size), 0) > > + > > #endif /*_ASM_GENERIC_BITOPS_FIND_H_ */ > > diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h > > index 90528f12bdfa..761fab5b60a7 100644 > > --- a/include/linux/bitmap.h > > +++ b/include/linux/bitmap.h > > @@ -66,6 +66,8 @@ > > * bitmap_allocate_region(bitmap, pos, order) Allocate specified bit region > > * bitmap_from_arr32(dst, buf, nbits) Copy nbits from u32[] buf to dst > > * bitmap_to_arr32(buf, src, nbits) Copy nbits from buf to u32[] dst > > + * bitmap_get_value8(map, start) Get 8bit value from map at start > > + * bitmap_set_value8(map, value, start) Set 8bit value to map at start > > * > > * Note, bitmap_zero() and bitmap_fill() operate over the region of > > * unsigned longs, that is, bits behind bitmap till the unsigned long > > @@ -488,6 +490,39 @@ static inline void bitmap_from_u64(unsigned long *dst, u64 mask) > > dst[1] = mask >> 32; > > } > > > > +/** > > + * bitmap_get_value8 - get an 8-bit value within a memory region > > + * @map: address to the bitmap memory region > > + * @start: bit offset of the 8-bit value; must be a multiple of 8 > > + * > > + * Returns the 8-bit value located at the @start bit offset within the @src > > + * memory region. > > + */ > > +static inline unsigned long bitmap_get_value8(const unsigned long *map, > > + unsigned long start) > > Why is the return type "unsigned long" where you know > it return the 8-bit value ? > > u8? The primary reason is to be consistent with the datatype of the bitmap: https://lkml.org/lkml/2019/1/12/26 This should also make it easier to extent to other sizes in the future since we won't have to change the interface in order to support 16-bit or 32-bit values -- they should easily fit within an unsigned long. William Breathitt Gray > > > > > +{ > > + const size_t index = BIT_WORD(start); > > + const unsigned long offset = start % BITS_PER_LONG; > > + > > + return (map[index] >> offset) & 0xFF; > > +} > > + > > +/** > > + * bitmap_set_value8 - set an 8-bit value within a memory region > > + * @map: address to the bitmap memory region > > + * @value: the 8-bit value; values wider than 8 bits may clobber bitmap > > + * @start: bit offset of the 8-bit value; must be a multiple of 8 > > + */ > > +static inline void bitmap_set_value8(unsigned long *map, unsigned long value, > > > Same here, "u8 value" > > > > > + unsigned long start) > > +{ > > + const size_t index = BIT_WORD(start); > > + const unsigned long offset = start % BITS_PER_LONG; > > + > > + map[index] &= ~(0xFF << offset); > > + map[index] |= value << offset; > > +} > > + > > #endif /* __ASSEMBLY__ */ > > > > #endif /* __LINUX_BITMAP_H */ > > diff --git a/include/linux/bitops.h b/include/linux/bitops.h > > index cf074bce3eb3..fb94a10f7853 100644 > > --- a/include/linux/bitops.h > > +++ b/include/linux/bitops.h > > @@ -40,6 +40,11 @@ extern unsigned long __sw_hweight64(__u64 w); > > (bit) < (size); \ > > (bit) = find_next_zero_bit((addr), (size), (bit) + 1)) > > > > +#define for_each_set_clump8(start, clump, bits, size) \ > > + for ((start) = find_first_clump8(&(clump), (bits), (size)); \ > > + (start) < (size); \ > > + (start) = find_next_clump8(&(clump), (bits), (size), (start) + 8)) > > + > > static inline int get_bitmask_order(unsigned int count) > > { > > int order; > > diff --git a/lib/find_bit.c b/lib/find_bit.c > > index 5c51eb45178a..e35a76b291e6 100644 > > --- a/lib/find_bit.c > > +++ b/lib/find_bit.c > > @@ -214,3 +214,17 @@ EXPORT_SYMBOL(find_next_bit_le); > > #endif > > > > #endif /* __BIG_ENDIAN */ > > + > > +unsigned long find_next_clump8(unsigned long *clump, const unsigned long *addr, > > > Ditto. "u8 *clump" > > > > > > + unsigned long size, unsigned long offset) > > +{ > > + offset = find_next_bit(addr, size, offset); > > + if (offset == size) > > + return size; > > + > > + offset = round_down(offset, 8); > > + *clump = bitmap_get_value8(addr, offset); > > + > > + return offset; > > +} > > +EXPORT_SYMBOL(find_next_clump8); > > -- > > 2.23.0 > > > > > -- > Best Regards > > Masahiro Yamada