From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44457ECE58C for ; Wed, 9 Oct 2019 17:32:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1885521848 for ; Wed, 9 Oct 2019 17:32:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="j3dNU27r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732676AbfJIRcH (ORCPT ); Wed, 9 Oct 2019 13:32:07 -0400 Received: from mail.skyhub.de ([5.9.137.197]:40570 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732396AbfJIRb4 (ORCPT ); Wed, 9 Oct 2019 13:31:56 -0400 Received: from zn.tnic (p200300EC2F0C2000CC8F9AE7D5DA1569.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:2000:cc8f:9ae7:d5da:1569]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BF3761EC0819; Wed, 9 Oct 2019 19:31:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1570642311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=TswlQo4vEF+AgJvamc1wb5Alk3PGWUEclAdiRh5vN/8=; b=j3dNU27rfdTrYdutjpQ9JRpVeZk5vrj9IRTq5BqHc1HnAM2iJRSD6YC4MevF7KOSOPwfpV QUYPFxtjStRxpXi2h9zvNv8NTjFJGVrVIcN8eOG3UOg/UKPgL+OPNdjqTBGaMERhYtNOzk pvNKT/Pg8egSrmyGVH6HDtkQnxl+31w= Date: Wed, 9 Oct 2019 19:31:48 +0200 From: Borislav Petkov To: Yu-cheng Yu Cc: linux-kernel@vger.kernel.org, x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Dave Hansen , Tony Luck , Andy Lutomirski , Rik van Riel , "Ravi V. Shankar" , Sebastian Andrzej Siewior , Fenghua Yu , Peter Zijlstra Subject: Re: [PATCH 6/6] x86/fpu/xstate: Rename validate_xstate_header() to validate_xstate_header_from_user() Message-ID: <20191009173148.GJ10395@zn.tnic> References: <20190925151022.21688-1-yu-cheng.yu@intel.com> <20190925151022.21688-7-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190925151022.21688-7-yu-cheng.yu@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 25, 2019 at 08:10:22AM -0700, Yu-cheng Yu wrote: > From: Fenghua Yu > > The function validate_xstate_header() validates an xstate header coming > from userspace (PTRACE or sigreturn). To make it clear, rename it to > validate_xstate_header_from_user(). > > Suggested-by: Dave Hansen > Signed-off-by: Fenghua Yu > Signed-off-by: Yu-cheng Yu This one is correct! \o/ > Reviewed-by: Dave Hansen > Reviewed-by: Tony Luck > --- > arch/x86/include/asm/fpu/xstate.h | 2 +- > arch/x86/kernel/fpu/regset.c | 2 +- > arch/x86/kernel/fpu/signal.c | 2 +- > arch/x86/kernel/fpu/xstate.c | 6 +++--- > 4 files changed, 6 insertions(+), 6 deletions(-) And I like patches like this one! :-) Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette