From: Viresh Kumar <viresh.kumar@linaro.org>
To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq/cpufreq_governor: Fix memory leak in cpufreq_dbs_governor_init
Date: Thu, 10 Oct 2019 12:19:17 +0530 [thread overview]
Message-ID: <20191010064917.4lsyd5zhwlfbql3d@vireshk-i7> (raw)
In-Reply-To: <20191009232643.20427-1-navid.emamdoost@gmail.com>
On 09-10-19, 18:26, Navid Emamdoost wrote:
> In the implementation of cpufreq_dbs_governor_init(), dbs_data is
> allocated and later is assigned to governor_data. But before that
> assignment, if gov->init() fails this allocation is not released.
> dbs_data should be released in case if gov->init() failure.
>
> Fixes: 714a2d9c8792 ("cpufreq: governor: split cpufreq_governor_dbs()")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
> drivers/cpufreq/cpufreq_governor.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c
> index 4bb054d0cb43..deb099d36266 100644
> --- a/drivers/cpufreq/cpufreq_governor.c
> +++ b/drivers/cpufreq/cpufreq_governor.c
> @@ -428,8 +428,10 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy)
> gov_attr_set_init(&dbs_data->attr_set, &policy_dbs->list);
>
> ret = gov->init(dbs_data);
> - if (ret)
> + if (ret) {
> + kfree(dbs_data);
> goto free_policy_dbs_info;
Maybe add another label right before kfree() at the bottom and jump there
instead. We wanted to share code in the error path.
> + }
>
> /*
> * The sampling interval should not be less than the transition latency
> --
> 2.17.1
--
viresh
prev parent reply other threads:[~2019-10-10 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 23:26 [PATCH] cpufreq/cpufreq_governor: Fix memory leak in cpufreq_dbs_governor_init Navid Emamdoost
2019-10-10 6:49 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010064917.4lsyd5zhwlfbql3d@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=emamd001@umn.edu \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).