From: Herbert Xu <herbert@gondor.apana.org.au>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Antoine Tenart <antoine.tenart@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
Pascal van Leeuwen <pvanleeuwen@verimatrix.com>,
Pascal van Leeuwen <pascalvanl@gmail.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] crypto: inside-secure - Fix a maybe-uninitialized warning
Date: Thu, 10 Oct 2019 23:54:51 +1100 [thread overview]
Message-ID: <20191010125451.GD31566@gondor.apana.org.au> (raw)
In-Reply-To: <20190930121520.1388317-1-arnd@arndb.de>
On Mon, Sep 30, 2019 at 02:14:33PM +0200, Arnd Bergmann wrote:
> A previous fixup avoided an unused variable warning but replaced
> it with a slightly scarier warning:
>
> drivers/crypto/inside-secure/safexcel.c:1100:6: error: variable 'irq' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
>
> This is harmless as it is impossible to get into this case, but
> the compiler has no way of knowing that. Add an explicit error
> handling case to make it obvious to both compilers and humans
> reading the source.
>
> Fixes: 212ef6f29e5b ("crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/crypto/inside-secure/safexcel.c | 2 ++
> 1 file changed, 2 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-10-10 12:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 12:14 [PATCH 1/3] crypto: inside-secure - Fix a maybe-uninitialized warning Arnd Bergmann
2019-09-30 12:14 ` [PATCH 2/3] crypto: inside-secure - Reduce stack usage Arnd Bergmann
2019-09-30 19:04 ` Pascal Van Leeuwen
2019-09-30 20:11 ` Arnd Bergmann
2019-09-30 21:09 ` Pascal Van Leeuwen
2019-10-01 18:49 ` Arnd Bergmann
2019-10-10 12:40 ` Herbert Xu
2019-09-30 12:14 ` [PATCH 3/3] crypto: inside-secure - Remove #ifdef checks Arnd Bergmann
2019-09-30 13:04 ` Bjorn Helgaas
2019-10-10 12:55 ` Herbert Xu
2019-10-17 13:26 ` Pascal Van Leeuwen
2019-10-17 13:47 ` Arnd Bergmann
2019-10-17 14:14 ` Pascal Van Leeuwen
2019-09-30 18:50 ` [PATCH 1/3] crypto: inside-secure - Fix a maybe-uninitialized warning Pascal Van Leeuwen
2019-10-10 12:54 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010125451.GD31566@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=antoine.tenart@bootlin.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pascalvanl@gmail.com \
--cc=pvanleeuwen@verimatrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).