From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A77F5C4360C for ; Thu, 10 Oct 2019 20:43:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68AE7206B6 for ; Thu, 10 Oct 2019 20:43:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="GtW/+rLP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727280AbfJJUnq (ORCPT ); Thu, 10 Oct 2019 16:43:46 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:39610 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726533AbfJJUnp (ORCPT ); Thu, 10 Oct 2019 16:43:45 -0400 Received: by mail-qt1-f196.google.com with SMTP id n7so10685825qtb.6 for ; Thu, 10 Oct 2019 13:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=Qnm/xOF1axoKltic9wOhlDvxehnhsqO9AK9SKyqjBMQ=; b=GtW/+rLPRQ8fSLH9IHSYXTdJDHRrh5NBGuGJCy8vNyG0Mm89yc5AVLhmyStQ64cL/a HnbJh2FlMxKowpSAcTU1qA2cV8F4fax78oYTI9G7GzFHIFJIjjmCiyF45F069J8xtBsq FTzcvoIoyKK8FrDmi1rF+IXznTcxHJKy2/Q9TJNTuHivI/SDXajuoRwTtaJzdIzFvaG4 fgKB/n9Uxu7Jn2HtGg6CpYx+2exCRXupYtm5QePgFMVgAPnmShQIy7ow0axRMe2CloPK OYUKC8qU82as3jECbuuKO8JzSDFSZ0wQalyI3uEmGxxUx4WX2LT6IbP5c4KM4r+7IqtP xrlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=Qnm/xOF1axoKltic9wOhlDvxehnhsqO9AK9SKyqjBMQ=; b=djthjg9pejv81FaeIpDlulex+2xJAxJz1pU0QDvPggux1qle9nThgnIph0V3Mvls2P eD3Xt5cWr57J8eCSfdwFsGJFz+j5ZkPGcc5D4GfjZtJyqiBlr2CQ3nIW4lV0SgHBtCK5 hFSxkQAddXW2dzVl9/BxDjQIsDEHrN3iPp4z3CjiOaDDE9sFjpGD5TnIsu6ugF1rwRRC oveEhveb9/UbRUzvpCsAZwkFRm94N27CHhRyp3T8PTgkLg29m5DxfYb67JeZ/7phTkQm 0emQR+1CaJCt4gqlDGwqldxidpPNjFWVJF9wIiJmbgDgQWdhwKJQ2JLnmqeTNlWQXXjM 8pPw== X-Gm-Message-State: APjAAAXAZP2zSbBy54xmp1kT1I3GJy+bAi9fversdQoDMzAK7GnUklTD qEGdYwSnkOM0FJBzITuzhNnN9g== X-Google-Smtp-Source: APXvYqyZrdHLApmMF/CBgXhn6HNdqvblVZ4R6rAbfwsXZm+T2cz+AV0njLlD4/0JZCQok6LgXNieSg== X-Received: by 2002:ac8:4311:: with SMTP id z17mr12075001qtm.213.1570740224747; Thu, 10 Oct 2019 13:43:44 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id p22sm3133129qkk.92.2019.10.10.13.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 13:43:44 -0700 (PDT) Date: Thu, 10 Oct 2019 13:43:26 -0700 From: Jakub Kicinski To: Sasha Levin Cc: Michael Kelley , davem@davemloft.net, Himadri Pandya , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "himadri18.07" Subject: Re: [PATCH] hv_sock: use HV_HYP_PAGE_SIZE instead of PAGE_SIZE_4K Message-ID: <20191010134326.608d363d@cakuba.netronome.com> In-Reply-To: <20191010170606.GA1396@sasha-vm> References: <20190725051125.10605-1-himadri18.07@gmail.com> <20191004154817.GL17454@sasha-vm> <20191010170606.GA1396@sasha-vm> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Oct 2019 13:06:06 -0400, Sasha Levin wrote: > On Fri, Oct 04, 2019 at 11:48:17AM -0400, Sasha Levin wrote: > >On Wed, Jul 31, 2019 at 01:02:03AM +0000, Michael Kelley wrote: > >>From: Himadri Pandya Sent: Wednesday, July 24, 2019 10:11 PM > >>> > >>>Older windows hosts require the hv_sock ring buffer to be defined > >>>using 4K pages. This was achieved by using the symbol PAGE_SIZE_4K > >>>defined specifically for this purpose. But now we have a new symbol > >>>HV_HYP_PAGE_SIZE defined in hyperv-tlfs which can be used for this. > >>> > >>>This patch removes the definition of symbol PAGE_SIZE_4K and replaces > >>>its usage with the symbol HV_HYP_PAGE_SIZE. This patch also aligns > >>>sndbuf and rcvbuf to hyper-v specific page size using HV_HYP_PAGE_SIZE > >>>instead of the guest page size(PAGE_SIZE) as hyper-v expects the page > >>>size to be 4K and it might not be the case on ARM64 architecture. > >>> > >>>Signed-off-by: Himadri Pandya > >>>--- > >>> net/vmw_vsock/hyperv_transport.c | 21 +++++++++++---------- > >>> 1 file changed, 11 insertions(+), 10 deletions(-) > >>> > >>>diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c > >>>index f2084e3f7aa4..ecb5d72d8010 100644 > >>>--- a/net/vmw_vsock/hyperv_transport.c > >>>+++ b/net/vmw_vsock/hyperv_transport.c > >>>@@ -13,15 +13,16 @@ > >>> #include > >>> #include > >>> #include > >>>+#include > >>> > >> > >>Reviewed-by: Michael Kelley > >> > >>This patch depends on a prerequisite patch in > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/hyperv > >> > >>that defines HV_HYP_PAGE_SIZE. > > > >David, the above prerequisite patch is now upstream, so this patch > >should be good to go. Would you take it through the net tree or should I > >do it via the hyperv tree? > > Ping? Is this a fix? It's slightly unclear from the description of the patch. I think the best course of action would be reposting it again, with either [PATCH net] in the subject and a Fixes tag if it's a fix, or [PATCH net-next] otherwise.