From: Kees Cook <keescook@chromium.org>
To: Will Deacon <will@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Elena Reshetova <elena.reshetova@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Hanjun Guo <guohanjun@huawei.com>,
Jan Glauber <jglauber@marvell.com>
Subject: Re: [PATCH v3 09/10] lib/refcount: Remove unused 'refcount_error_report()' function
Date: Thu, 10 Oct 2019 13:50:14 -0700 [thread overview]
Message-ID: <201910101349.9400E7D0@keescook> (raw)
In-Reply-To: <20191007154703.5574-10-will@kernel.org>
On Mon, Oct 07, 2019 at 04:47:02PM +0100, Will Deacon wrote:
> 'refcount_error_report()' has no callers. Remove it.
Seems like this could be collapsed into patch 8? Either way:
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Elena Reshetova <elena.reshetova@intel.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Will Deacon <will@kernel.org>
> ---
> include/linux/kernel.h | 7 -------
> kernel/panic.c | 11 -----------
> 2 files changed, 18 deletions(-)
>
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> index d83d403dac2e..09f759228e3f 100644
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -328,13 +328,6 @@ extern int oops_may_print(void);
> void do_exit(long error_code) __noreturn;
> void complete_and_exit(struct completion *, long) __noreturn;
>
> -#ifdef CONFIG_ARCH_HAS_REFCOUNT
> -void refcount_error_report(struct pt_regs *regs, const char *err);
> -#else
> -static inline void refcount_error_report(struct pt_regs *regs, const char *err)
> -{ }
> -#endif
> -
> /* Internal, do not use. */
> int __must_check _kstrtoul(const char *s, unsigned int base, unsigned long *res);
> int __must_check _kstrtol(const char *s, unsigned int base, long *res);
> diff --git a/kernel/panic.c b/kernel/panic.c
> index 47e8ebccc22b..10d05fd4f9c3 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -670,17 +670,6 @@ EXPORT_SYMBOL(__stack_chk_fail);
>
> #endif
>
> -#ifdef CONFIG_ARCH_HAS_REFCOUNT
> -void refcount_error_report(struct pt_regs *regs, const char *err)
> -{
> - WARN_RATELIMIT(1, "refcount_t %s at %pB in %s[%d], uid/euid: %u/%u\n",
> - err, (void *)instruction_pointer(regs),
> - current->comm, task_pid_nr(current),
> - from_kuid_munged(&init_user_ns, current_uid()),
> - from_kuid_munged(&init_user_ns, current_euid()));
> -}
> -#endif
> -
> core_param(panic, panic_timeout, int, 0644);
> core_param(panic_print, panic_print, ulong, 0644);
> core_param(pause_on_oops, pause_on_oops, int, 0644);
> --
> 2.23.0.581.g78d2f28ef7-goog
>
--
Kees Cook
next prev parent reply other threads:[~2019-10-10 20:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 15:46 [PATCH v3 00/10] Rework REFCOUNT_FULL using atomic_fetch_* operations Will Deacon
2019-10-07 15:46 ` [PATCH v3 01/10] lib/refcount: Define constants for saturation and max refcount values Will Deacon
2019-10-07 15:46 ` [PATCH v3 02/10] lib/refcount: Ensure integer operands are treated as signed Will Deacon
2019-10-07 15:46 ` [PATCH v3 03/10] lib/refcount: Remove unused refcount_*_checked() variants Will Deacon
2019-10-07 15:46 ` [PATCH v3 04/10] lib/refcount: Move bulk of REFCOUNT_FULL implementation into header Will Deacon
2019-10-07 15:46 ` [PATCH v3 05/10] lib/refcount: Improve performance of generic REFCOUNT_FULL code Will Deacon
2019-10-09 9:25 ` Peter Zijlstra
2019-10-09 11:35 ` Peter Zijlstra
2019-10-09 16:44 ` Will Deacon
2019-10-09 17:41 ` Peter Zijlstra
2019-10-07 15:46 ` [PATCH v3 06/10] lib/refcount: Move saturation warnings out of line Will Deacon
2019-10-10 20:48 ` Kees Cook
2019-10-11 12:09 ` Will Deacon
2019-10-07 15:47 ` [PATCH v3 07/10] lib/refcount: Consolidate REFCOUNT_{MAX,SATURATED} definitions Will Deacon
2019-10-07 15:47 ` [PATCH v3 08/10] refcount: Consolidate implementations of refcount_t Will Deacon
2019-10-10 20:49 ` Kees Cook
2019-10-07 15:47 ` [PATCH v3 09/10] lib/refcount: Remove unused 'refcount_error_report()' function Will Deacon
2019-10-10 20:50 ` Kees Cook [this message]
2019-10-11 12:12 ` Will Deacon
2019-10-07 15:47 ` [PATCH v3 10/10] drivers/lkdtm: Remove references to CONFIG_REFCOUNT_FULL Will Deacon
2019-10-10 20:50 ` Kees Cook
2019-10-09 10:01 ` [PATCH v3 00/10] Rework REFCOUNT_FULL using atomic_fetch_* operations Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910101349.9400E7D0@keescook \
--to=keescook@chromium.org \
--cc=ard.biesheuvel@linaro.org \
--cc=elena.reshetova@intel.com \
--cc=guohanjun@huawei.com \
--cc=jglauber@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).