From: Alexander Lobakin <alobakin@dlink.ru>
To: "David S. Miller" <davem@davemloft.net>
Cc: Edward Cree <ecree@solarflare.com>,
Jiri Pirko <jiri@mellanox.com>,
Eric Dumazet <edumazet@google.com>,
Ido Schimmel <idosch@mellanox.com>,
Paolo Abeni <pabeni@redhat.com>,
Petr Machata <petrm@mellanox.com>,
Sabrina Dubroca <sd@queasysnail.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Lobakin <alobakin@dlink.ru>
Subject: [PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush
Date: Thu, 10 Oct 2019 17:42:26 +0300 [thread overview]
Message-ID: <20191010144226.4115-3-alobakin@dlink.ru> (raw)
In-Reply-To: <20191010144226.4115-1-alobakin@dlink.ru>
Commit 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL
skbs") have introduced a sysctl variable gro_normal_batch for defining
a limit for listified Rx of GRO_NORMAL skbs. The initial value of 8 is
purely arbitrary and has been chosen, I believe, as a minimal safe
default.
However, several tests show that it's rather suboptimal and doesn't
allow to take a full advantage of listified processing. The best and
the most balanced results have been achieved with a batches of 16 skbs
per flush.
So double the default value to give a yet another boost for Rx path.
It remains configurable via sysctl anyway, so may be fine-tuned for
each hardware.
Signed-off-by: Alexander Lobakin <alobakin@dlink.ru>
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index a33f56b439ce..4f60444bb766 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -4189,7 +4189,7 @@ int dev_weight_tx_bias __read_mostly = 1; /* bias for output_queue quota */
int dev_rx_weight __read_mostly = 64;
int dev_tx_weight __read_mostly = 64;
/* Maximum number of GRO_NORMAL skbs to batch up for list-RX */
-int gro_normal_batch __read_mostly = 8;
+int gro_normal_batch __read_mostly = 16;
/* Called with irq disabled */
static inline void ____napi_schedule(struct softnet_data *sd,
--
2.23.0
next prev parent reply other threads:[~2019-10-10 14:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 14:42 [PATCH net-next 0/2] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() Alexander Lobakin
2019-10-10 14:42 ` [PATCH net-next1/2] " Alexander Lobakin
2019-10-10 18:23 ` Edward Cree
2019-10-11 7:26 ` Alexander Lobakin
2019-10-11 9:20 ` Edward Cree
2019-10-11 9:24 ` Alexander Lobakin
2019-10-10 14:42 ` Alexander Lobakin [this message]
2019-10-10 18:16 ` [PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush Edward Cree
2019-10-11 7:23 ` Alexander Lobakin
2019-10-12 9:22 ` Alexander Lobakin
2019-10-12 11:18 ` Eric Dumazet
2019-10-12 11:51 ` Alexander Lobakin
2019-10-11 12:23 ` [PATCH net-next 0/2] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() Ilias Apalodimas
2019-10-11 12:27 ` Alexander Lobakin
2019-10-11 12:32 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010144226.4115-3-alobakin@dlink.ru \
--to=alobakin@dlink.ru \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jaswinder.singh@linaro.org \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@mellanox.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).