From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D438ECE58D for ; Thu, 10 Oct 2019 19:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03754206A1 for ; Thu, 10 Oct 2019 19:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570736048; bh=lzfJ/g7tajR317T7qaU/Sdfc2M0Tct3F0/pLL4V17GQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SnaVsJkzE5l7yOi+V2uJn1uHAOKgpVtq3OgCMZxwpaYF5jWUd35RJEapkaONEKnnX 4Cu7vWkhshe6nSFh5ma9fo79jHIbZbYVdW/BELqgdCkoUuK7tlWJYxmCqY03qLwUZF V95KyynoA2GGgBDAbZDAdqLGhvmyqu16JqxrCkzo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726083AbfJJTd7 (ORCPT ); Thu, 10 Oct 2019 15:33:59 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:46639 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbfJJTd7 (ORCPT ); Thu, 10 Oct 2019 15:33:59 -0400 Received: by mail-oi1-f193.google.com with SMTP id k25so5928668oiw.13; Thu, 10 Oct 2019 12:33:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7ET4N4h1mz+QXnjZEYhffwJ+S0rSM6M0DCW5sXhGLr4=; b=q27Wk4WXPi8qpC5UNFYVxQ294oPik1VDg4Q+UG2rdvWy81v8wv6VAgwbHa9zTCv8Cp 9U0K6oDCJy06/Laa4NdgTahqPQ8qcW1th0UQrsfuqXFBi/GeikSKYMuxCUNvb6p9MqAv o8h1XrrtkdGsH9kvhHWDmOunE+qeqLbCCey2Zd1xp0r4Bk5LZX8fLE9J6KXmUfqEvHHz 6Xo19KpDOMblQeHv/S8wgnbugcYaO4gwU6Ih95JplnYH8oR0DmfgwJR4Zdau5u+isfWF ELIPxpGnUWff9p3MeZhRgEkxWNyV9LRKCf94BNBhCHpABBYsO+k59WGBc0g7FbjDZaks +fRg== X-Gm-Message-State: APjAAAUE2H+aiOqSID4/0QzXOpUJoBu4yWBR1GTVS/harTRIVtK/Czq/ rES1gWF/ID1C0AWZJL7Csg== X-Google-Smtp-Source: APXvYqyuT5yi9lOX+HY+jMDUqyMXIegTNgwLUO2uJeseCSix9lpmMgQ5/3duA7qI2l/FDDlVpw2grA== X-Received: by 2002:aca:36d5:: with SMTP id d204mr8794400oia.51.1570736038102; Thu, 10 Oct 2019 12:33:58 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id n186sm2042419oih.58.2019.10.10.12.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 12:33:57 -0700 (PDT) Date: Thu, 10 Oct 2019 14:33:56 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Mark Rutland , Kukjin Kim , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Santosh Shilimkar , Thierry Reding , Jonathan Hunter , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v3 02/10] dt-bindings: sram: Convert Samsung Exynos SYSRAM bindings to json-schema Message-ID: <20191010193356.GA9975@bogus> References: <20191002164316.14905-1-krzk@kernel.org> <20191002164316.14905-2-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191002164316.14905-2-krzk@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 02, 2019 at 06:43:08PM +0200, Krzysztof Kozlowski wrote: > Convert Samsung Exynos SYSRAM bindings to DT schema format using > json-schema. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v2: > 1. Use sram as name of node in example. > > Changes since v1: > 1. Indent example with four spaces (more readable). > --- > .../devicetree/bindings/sram/samsung-sram.txt | 38 ------------ > .../bindings/sram/samsung-sram.yaml | 58 +++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 59 insertions(+), 39 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sram/samsung-sram.txt > create mode 100644 Documentation/devicetree/bindings/sram/samsung-sram.yaml > diff --git a/Documentation/devicetree/bindings/sram/samsung-sram.yaml b/Documentation/devicetree/bindings/sram/samsung-sram.yaml > new file mode 100644 > index 000000000000..3e77c434ecca > --- /dev/null > +++ b/Documentation/devicetree/bindings/sram/samsung-sram.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sram/samsung-sram.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung Exynos SoC SYSRAM for SMP bringup > + > +maintainers: > + - Krzysztof Kozlowski > + > +description: |+ > + Samsung SMP-capable Exynos SoCs use part of the SYSRAM for the bringup > + of the secondary cores. Once the core gets powered up it executes the > + code that is residing at some specific location of the SYSRAM. > + > + Therefore reserved section sub-nodes have to be added to the mmio-sram > + declaration. These nodes are of two types depending upon secure or > + non-secure execution environment. > + > +allOf: > + - $ref: "sram.yaml#" > + > +properties: > + $nodename: > + pattern: "^sysram(@.*)?" As you are renaming all the node names, this will no longer work. If you change it to 'sram', that's going to match others, but would still work as long as the child node names are unique to Samsung. If you change them to '*-sram' then, you'd have to come up with something else. That probably means using 'compatible' strings. At that point, it's kind of silly to just be validating what your are using to select the schema. It may be better to just add the compatible strings into sram.yaml if that's the only difference. > + > +patternProperties: > + "^([a-z]*-)?sysram@[a-f0-9]$": > + type: object > + > + properties: > + compatible: > + description: > + Depending upon boot mode > + enum: > + - samsung,exynos4210-sysram # for Secure SYSRAM > + - samsung,exynos4210-sysram-ns # for Non-secure SYSRAM > +