LKML Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the staging.current tree
@ 2019-10-10 20:42 Stephen Rothwell
  2019-10-11  8:10 ` Jonathan Cameron
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2019-10-10 20:42 UTC (permalink / raw)
  To: Greg KH
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Lorenzo Bianconi, Jonathan Cameron

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

In commit

  85ae3aeedecc ("iio: imu: st_lsm6dsx: forbid 0 sensor sensitivity")

Fixes tag

  Fixes: c8d4066c7246 ("iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 0f7e17286b45 ("iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: linux-next: Fixes tag needs some work in the staging.current tree
  2019-10-10 20:42 linux-next: Fixes tag needs some work in the staging.current tree Stephen Rothwell
@ 2019-10-11  8:10 ` Jonathan Cameron
  2019-10-11  8:29   ` Greg KH
  0 siblings, 1 reply; 7+ messages in thread
From: Jonathan Cameron @ 2019-10-11  8:10 UTC (permalink / raw)
  To: Stephen Rothwell, Greg KH
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Lorenzo Bianconi

Hi Stephen

Sorry, I've clearly let another one of these through.

Stupid question of the day.  Don't suppose you can share how you check these?

Thanks,

Jonathan


-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] 
Sent: 10 October 2019 21:43
To: Greg KH <greg@kroah.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Lorenzo Bianconi <lorenzo@kernel.org>; Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: linux-next: Fixes tag needs some work in the staging.current tree

Hi all,

In commit

  85ae3aeedecc ("iio: imu: st_lsm6dsx: forbid 0 sensor sensitivity")

Fixes tag

  Fixes: c8d4066c7246 ("iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 0f7e17286b45 ("iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: Fixes tag needs some work in the staging.current tree
  2019-10-11  8:10 ` Jonathan Cameron
@ 2019-10-11  8:29   ` Greg KH
  2019-10-11 10:36     ` Stephen Rothwell
  0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2019-10-11  8:29 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Lorenzo Bianconi

On Fri, Oct 11, 2019 at 08:10:23AM +0000, Jonathan Cameron wrote:
> Hi Stephen
> 
> Sorry, I've clearly let another one of these through.
> 
> Stupid question of the day.  Don't suppose you can share how you check these?

There's a script, that I posted to the workflows mailing list, that
should check these, based on Stephen's script.

But it didn't seem to catch this problem, which is odd, I must have
messed something up...

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: Fixes tag needs some work in the staging.current tree
  2019-10-11  8:29   ` Greg KH
@ 2019-10-11 10:36     ` Stephen Rothwell
  0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2019-10-11 10:36 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Greg KH, Linux Next Mailing List, Linux Kernel Mailing List,
	Lorenzo Bianconi

[-- Attachment #1.1: Type: text/plain, Size: 752 bytes --]

Hi Jonathan,

On Fri, 11 Oct 2019 10:29:02 +0200 Greg KH <greg@kroah.com> wrote:
>
> On Fri, Oct 11, 2019 at 08:10:23AM +0000, Jonathan Cameron wrote:
> > Hi Stephen
> > 
> > Sorry, I've clearly let another one of these through.
> > 
> > Stupid question of the day.  Don't suppose you can share how you check these?  
> 
> There's a script, that I posted to the workflows mailing list, that
> should check these, based on Stephen's script.
> 
> But it didn't seem to catch this problem, which is odd, I must have
> messed something up...

Attached is my script.  It takes a range of commits to check.  Usually
after I fetch a tree I pass it "^origin/master <old head of tree>...<new head of tree>".

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: check_fixes --]
[-- Type: application/x-shellscript, Size: 4344 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: Fixes tag needs some work in the staging.current tree
  2019-07-28 13:13 ` Greg KH
@ 2019-07-29  8:24   ` Jonathan Cameron
  0 siblings, 0 replies; 7+ messages in thread
From: Jonathan Cameron @ 2019-07-29  8:24 UTC (permalink / raw)
  To: Greg KH
  Cc: Stephen Rothwell, Artur Rojek, Linux Next Mailing List,
	Linux Kernel Mailing List, Maarten ter Huurne

On Sun, 28 Jul 2019 15:13:55 +0200
Greg KH <greg@kroah.com> wrote:

> On Sun, Jul 28, 2019 at 11:01:47PM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   5a304e1a4ea0 ("IIO: Ingenic JZ47xx: Set clock divider on probe")
> > 
> > Fixes tag
> > 
> >   Fixes: 1a78daea107d ("iio: adc: probe should set clock divider")
> > 
> > has these problem(s):
> > 
> >   - Subject does not match target commit subject
> >     Just use
> > 	git log -1 --format='Fixes: %h ("%s")'
> > 
> > Did you mean
> > 
> > Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")  
> 
> Jonathan, I'm guessing this was your fault...
> 
> greg k-h

Indeed should have spotted that one.
Sorry about that, I'll check these more thoroughly.

Thanks for pointing it out Stephen!

Jonathan


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: Fixes tag needs some work in the staging.current tree
  2019-07-28 13:01 Stephen Rothwell
@ 2019-07-28 13:13 ` Greg KH
  2019-07-29  8:24   ` Jonathan Cameron
  0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2019-07-28 13:13 UTC (permalink / raw)
  To: Stephen Rothwell, Jonathan Cameron, Artur Rojek
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Maarten ter Huurne

On Sun, Jul 28, 2019 at 11:01:47PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   5a304e1a4ea0 ("IIO: Ingenic JZ47xx: Set clock divider on probe")
> 
> Fixes tag
> 
>   Fixes: 1a78daea107d ("iio: adc: probe should set clock divider")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Did you mean
> 
> Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")

Jonathan, I'm guessing this was your fault...

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread

* linux-next: Fixes tag needs some work in the staging.current tree
@ 2019-07-28 13:01 Stephen Rothwell
  2019-07-28 13:13 ` Greg KH
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2019-07-28 13:01 UTC (permalink / raw)
  To: Greg KH
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Maarten ter Huurne, Jonathan Cameron, Artur Rojek

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi all,

In commit

  5a304e1a4ea0 ("IIO: Ingenic JZ47xx: Set clock divider on probe")

Fixes tag

  Fixes: 1a78daea107d ("iio: adc: probe should set clock divider")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-10 20:42 linux-next: Fixes tag needs some work in the staging.current tree Stephen Rothwell
2019-10-11  8:10 ` Jonathan Cameron
2019-10-11  8:29   ` Greg KH
2019-10-11 10:36     ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2019-07-28 13:01 Stephen Rothwell
2019-07-28 13:13 ` Greg KH
2019-07-29  8:24   ` Jonathan Cameron

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox