LKML Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the v4l-dvb tree
@ 2019-10-10 20:47 Stephen Rothwell
  2019-10-11 12:28 ` Benoit Parrot
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2019-10-10 20:47 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Benoit Parrot, Hans Verkuil

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi all,

In commit

  e20b248051ca ("media: ti-vpe: vpe: Make sure YUYV is set as default format")

Fixes tag

  Fixes: 40cc823f7005 ("media: ti-vpe: Add support for NV21 format")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: b2bb3d822f2c ("media: ti-vpe: Add support for NV21 format")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Fixes tag needs some work in the v4l-dvb tree
  2019-10-10 20:47 linux-next: Fixes tag needs some work in the v4l-dvb tree Stephen Rothwell
@ 2019-10-11 12:28 ` Benoit Parrot
  0 siblings, 0 replies; 8+ messages in thread
From: Benoit Parrot @ 2019-10-11 12:28 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mauro Carvalho Chehab, Linux Next Mailing List,
	Linux Kernel Mailing List, Hans Verkuil

Stephen Rothwell <sfr@canb.auug.org.au> wrote on Fri [2019-Oct-11 07:47:02 +1100]:
> Hi all,
> 
> In commit
> 
>   e20b248051ca ("media: ti-vpe: vpe: Make sure YUYV is set as default format")
> 
> Fixes tag
> 
>   Fixes: 40cc823f7005 ("media: ti-vpe: Add support for NV21 format")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: b2bb3d822f2c ("media: ti-vpe: Add support for NV21 format")

Ah, yes.
This was obviously missed through the rebase, sorry.

Benoit

> 
> -- 
> Cheers,
> Stephen Rothwell



^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Fixes tag needs some work in the v4l-dvb tree
@ 2019-06-22 13:47 Stephen Rothwell
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2019-06-22 13:47 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Robert Jarzmik, Sakari Ailus

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

Hi Mauro,

In commit

  3a959dcd11a4 ("media: mt9m111: add regulator support")

Fixes tag

  Fixes: 5c10113cc668 ("media: mt9m111: make a standalone v4l2 subdevice")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

  5d7cc01b20fc ("[media] media: mt9m111: make a standalone v4l2 subdevice")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Fixes tag needs some work in the v4l-dvb tree
  2019-05-29 21:05 ` Niklas Söderlund
@ 2019-05-29 21:11   ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 8+ messages in thread
From: Mauro Carvalho Chehab @ 2019-05-29 21:11 UTC (permalink / raw)
  To: Niklas Söderlund
  Cc: Stephen Rothwell, Linux Kernel Mailing List,
	Linux Next Mailing List, Hans Verkuil

Em Wed, 29 May 2019 23:05:11 +0200
"Niklas Söderlund" <niklas.soderlund@ragnatech.se> escreveu:

> Hi Stephen, Mauro,
> 
> On 2019-05-29 08:04:54 +1000, Stephen Rothwell wrote:
> > Hi Mauro,
> > 
> > In commit
> > 
> >   0c310868826e ("media: rcar-csi2: Fix coccinelle warning for PTR_ERR_OR_ZERO()")
> > 
> > Fixes tag
> > 
> >   Fixes: 3ae854cafd76 ("rcar-csi2: Use standby mode instead of resetting")
> > 
> > has these problem(s):
> > 
> >   - Target SHA1 does not exist
> > 
> > Did you mean
> > 
> > Fixes: d245a940d97b ("media: rcar-csi2: Use standby mode instead of resetting")  
> 
> Yes I meant d245a940d97b commit, for some reason I was on the wrong 
> branch when looking up the sha1 for the fixes tag and used one from a 
> local development branch.
> 
> This is my mess, sorry about that. What can I do to help fix it?

That's a good question... no idea. Rebasing the tree due to that sounds
a bad idea. Reverting/reapplying also doesn't sound the best thing,
as it will just make -stable people even more confused.

I should probably try to implement a script like the one Stephen
has on my patch import scripts.

Thanks,
Mauro

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Fixes tag needs some work in the v4l-dvb tree
  2019-05-28 22:04 Stephen Rothwell
@ 2019-05-29 21:05 ` Niklas Söderlund
  2019-05-29 21:11   ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 8+ messages in thread
From: Niklas Söderlund @ 2019-05-29 21:05 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mauro Carvalho Chehab, Linux Kernel Mailing List,
	Linux Next Mailing List, Hans Verkuil

Hi Stephen, Mauro,

On 2019-05-29 08:04:54 +1000, Stephen Rothwell wrote:
> Hi Mauro,
> 
> In commit
> 
>   0c310868826e ("media: rcar-csi2: Fix coccinelle warning for PTR_ERR_OR_ZERO()")
> 
> Fixes tag
> 
>   Fixes: 3ae854cafd76 ("rcar-csi2: Use standby mode instead of resetting")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: d245a940d97b ("media: rcar-csi2: Use standby mode instead of resetting")

Yes I meant d245a940d97b commit, for some reason I was on the wrong 
branch when looking up the sha1 for the fixes tag and used one from a 
local development branch.

This is my mess, sorry about that. What can I do to help fix it?

-- 
Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Fixes tag needs some work in the v4l-dvb tree
@ 2019-05-28 22:04 Stephen Rothwell
  2019-05-29 21:05 ` Niklas Söderlund
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2019-05-28 22:04 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Linux Kernel Mailing List
  Cc: Linux Next Mailing List, Niklas Söderlund, Hans Verkuil

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi Mauro,

In commit

  0c310868826e ("media: rcar-csi2: Fix coccinelle warning for PTR_ERR_OR_ZERO()")

Fixes tag

  Fixes: 3ae854cafd76 ("rcar-csi2: Use standby mode instead of resetting")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: d245a940d97b ("media: rcar-csi2: Use standby mode instead of resetting")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Fixes tag needs some work in the v4l-dvb tree
@ 2019-04-22 21:22 Stephen Rothwell
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2019-04-22 21:22 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Alexander Potapenko, Hans Verkuil

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Hi Mauro,

In commit

  dad7e270ba71 ("media: vivid: use vfree() instead of kfree() for dev->bitmap_cap")

Fixes tag

  Fixes: ef834f7836ec0 ("[media] vivid: add the video capture and output

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags across more than one line.  Also, keep
all the tags on one group.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Fixes tag needs some work in the v4l-dvb tree
@ 2019-01-16 21:02 Stephen Rothwell
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2019-01-16 21:02 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Manivannan Sadhasivam, Paul Gortmaker

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

[I am experimenting with checking the Fixes tags in commits in linux-next.
Please let me know if you think I am being too strict.]

Hi Mauro,

Commit

  961304d17a61 ("media: dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor")

has a malformed Fixes tag.

The subject in the Fixes tag is usually surrounded by (" and ").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-10 20:47 linux-next: Fixes tag needs some work in the v4l-dvb tree Stephen Rothwell
2019-10-11 12:28 ` Benoit Parrot
  -- strict thread matches above, loose matches on Subject: below --
2019-06-22 13:47 Stephen Rothwell
2019-05-28 22:04 Stephen Rothwell
2019-05-29 21:05 ` Niklas Söderlund
2019-05-29 21:11   ` Mauro Carvalho Chehab
2019-04-22 21:22 Stephen Rothwell
2019-01-16 21:02 Stephen Rothwell

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox