From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Kukjin Kim" <kgene@kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Jason Cooper" <jason@lakedaemon.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 02/10] dt-bindings: sram: Convert Samsung Exynos SYSRAM bindings to json-schema
Date: Fri, 11 Oct 2019 09:52:53 +0200 [thread overview]
Message-ID: <20191011075253.GA7998@pi3> (raw)
In-Reply-To: <20191010193356.GA9975@bogus>
On Thu, Oct 10, 2019 at 02:33:56PM -0500, Rob Herring wrote:
> On Wed, Oct 02, 2019 at 06:43:08PM +0200, Krzysztof Kozlowski wrote:
> > Convert Samsung Exynos SYSRAM bindings to DT schema format using
> > json-schema.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > ---
> >
> > Changes since v2:
> > 1. Use sram as name of node in example.
> >
> > Changes since v1:
> > 1. Indent example with four spaces (more readable).
> > ---
> > .../devicetree/bindings/sram/samsung-sram.txt | 38 ------------
> > .../bindings/sram/samsung-sram.yaml | 58 +++++++++++++++++++
> > MAINTAINERS | 2 +-
> > 3 files changed, 59 insertions(+), 39 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/sram/samsung-sram.txt
> > create mode 100644 Documentation/devicetree/bindings/sram/samsung-sram.yaml
>
>
> > diff --git a/Documentation/devicetree/bindings/sram/samsung-sram.yaml b/Documentation/devicetree/bindings/sram/samsung-sram.yaml
> > new file mode 100644
> > index 000000000000..3e77c434ecca
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sram/samsung-sram.yaml
> > @@ -0,0 +1,58 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sram/samsung-sram.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Samsung Exynos SoC SYSRAM for SMP bringup
> > +
> > +maintainers:
> > + - Krzysztof Kozlowski <krzk@kernel.org>
> > +
> > +description: |+
> > + Samsung SMP-capable Exynos SoCs use part of the SYSRAM for the bringup
> > + of the secondary cores. Once the core gets powered up it executes the
> > + code that is residing at some specific location of the SYSRAM.
> > +
> > + Therefore reserved section sub-nodes have to be added to the mmio-sram
> > + declaration. These nodes are of two types depending upon secure or
> > + non-secure execution environment.
> > +
> > +allOf:
> > + - $ref: "sram.yaml#"
> > +
> > +properties:
> > + $nodename:
> > + pattern: "^sysram(@.*)?"
>
> As you are renaming all the node names, this will no longer work. If you
> change it to 'sram', that's going to match others, but would still work
> as long as the child node names are unique to Samsung. If you change
> them to '*-sram' then, you'd have to come up with something else. That
> probably means using 'compatible' strings. At that point, it's kind of
> silly to just be validating what your are using to select the schema. It
> may be better to just add the compatible strings into sram.yaml if
> that's the only difference.
You're right. I'll move them to sram.yaml and maybe add also example.
Best regards,
Krzysztof
next prev parent reply other threads:[~2019-10-11 7:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 16:43 [PATCH v3 01/10] dt-bindings: sram: Convert SRAM bindings to json-schema Krzysztof Kozlowski
2019-10-02 16:43 ` [PATCH v3 02/10] dt-bindings: sram: Convert Samsung Exynos SYSRAM " Krzysztof Kozlowski
2019-10-10 19:33 ` Rob Herring
2019-10-11 7:52 ` Krzysztof Kozlowski [this message]
2019-10-02 16:43 ` [PATCH v3 03/10] ARM: dts: exynos: Rename SysRAM node to "sram" Krzysztof Kozlowski
2019-10-06 15:48 ` Krzysztof Kozlowski
2019-10-02 16:43 ` [PATCH v3 04/10] arm64: dts: tegra: Rename sysram " Krzysztof Kozlowski
2019-10-02 16:43 ` [PATCH v3 05/10] ARM: dts: dove: Rename "sa-sram" " Krzysztof Kozlowski
2019-10-08 9:44 ` Gregory CLEMENT
2019-10-02 16:43 ` [PATCH v3 06/10] ARM: dts: imx: Rename "iram" " Krzysztof Kozlowski
2019-10-14 11:32 ` Shawn Guo
2019-10-16 16:18 ` Krzysztof Kozlowski
2019-10-25 2:39 ` Shawn Guo
2019-10-02 16:43 ` [PATCH v3 07/10] ARM: dts: keystone: Rename "msmram" " Krzysztof Kozlowski
2019-10-02 16:43 ` [PATCH v3 08/10] ARM: dts: tegra: Rename "iram" " Krzysztof Kozlowski
2019-10-02 16:43 ` [PATCH v3 09/10] ARM: dts: am: Rename "ocmcram" " Krzysztof Kozlowski
2019-10-02 16:43 ` [PATCH v3 10/10] ARM: dts: omap: " Krzysztof Kozlowski
2019-10-22 16:35 ` Tony Lindgren
2019-10-10 19:12 ` [PATCH v3 01/10] dt-bindings: sram: Convert SRAM bindings to json-schema Rob Herring
2019-10-21 13:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011075253.GA7998@pi3 \
--to=krzk@kernel.org \
--cc=andrew@lunn.ch \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawnguo@kernel.org \
--cc=ssantosh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).