From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A96ECE58E for ; Fri, 11 Oct 2019 16:09:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD006206CD for ; Fri, 11 Oct 2019 16:09:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="k3VEdnK1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728218AbfJKQJ1 (ORCPT ); Fri, 11 Oct 2019 12:09:27 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:37636 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727984AbfJKQJ0 (ORCPT ); Fri, 11 Oct 2019 12:09:26 -0400 Received: by mail-pf1-f196.google.com with SMTP id y5so6371063pfo.4 for ; Fri, 11 Oct 2019 09:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rz208JH/bAYgb34feMbXc7rOAmJSapYVvu3TBVmWgf0=; b=k3VEdnK1XLODdhPbFCe/vXjRUrVGk8LtbhfzFlecnP8Kmv9f4bYkCsfO3n/TqN0AdN qBPqcub0N0dKdLHi1OxIweb3/6eczWoee7LuePEuJPxxCrmCNRf0LI9uLqFq5rTIaXHw uP6X5tVwyIUzUKipWUOB9mLE9R+uA81t/qC+c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rz208JH/bAYgb34feMbXc7rOAmJSapYVvu3TBVmWgf0=; b=B5JAw6aJMg3fW7nCE2EUSjVoQBoojZfwFju+UuV5uzYdH0jZw9NCGV3O45fKej+ifg 1E/4CEL0eD8PheeqZ8+cegRiEEm8mProx3tVIvyaxXoUpmlf2d8N0oeYf/5JeQriH7s2 xUpJbhwaX9ZdWaePqUhAeSZWv5kOsLzvs1Aye4TiJ2Ve7DH/In0mqT/bZ3OFjs25FDGr 3CEaInRRis6Zlp41HC1yz5i0bHmdX0xXiicjr/Uw2NaZ1l6uOyMh7JG9+MyasykUE0jS PFB6zucx1OgKDIPh+0q7klpX9gtsIgrJUPPEYXn0Qenepwwck/zmvvY+VSpKtxZcIlPB Sb/Q== X-Gm-Message-State: APjAAAW4WtjxEMt6LVNDQy2caIrha/FymMN1iEY6xiqrWYQ2pd1nDzC7 5dKw90ca1YX0q/w2QSHmqrkung== X-Google-Smtp-Source: APXvYqzRI04wjSOtKB/baIR7njDLMah96e9dDVUlsW+Ic2nxptL0dLB9zZ6sMSyGO7t7MBKia+2VpQ== X-Received: by 2002:a63:b5b:: with SMTP id a27mr18354873pgl.262.1570810165767; Fri, 11 Oct 2019 09:09:25 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d3sm8459551pgb.3.2019.10.11.09.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2019 09:09:24 -0700 (PDT) Date: Fri, 11 Oct 2019 09:09:22 -0700 From: Kees Cook To: Michael Ellerman Cc: Borislav Petkov , Rick Edgecombe , Dave Hansen , Andy Lutomirski , Arnd Bergmann , Heiko Carstens , Will Deacon , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Michal Simek , linux-parisc@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, linux-kernel@vger.kernel.org, Joel Stanley , Segher Boessenkool Subject: Re: [PATCH v2 02/29] powerpc: Remove PT_NOTE workaround Message-ID: <201910110908.040009F27@keescook> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-3-keescook@chromium.org> <878sprx1br.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878sprx1br.fsf@mpe.ellerman.id.au> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 11, 2019 at 05:07:04PM +1100, Michael Ellerman wrote: > Kees Cook writes: > > In preparation for moving NOTES into RO_DATA, remove the PT_NOTE > > workaround since the kernel requires at least gcc 4.6 now. > > > > Signed-off-by: Kees Cook > > --- > > arch/powerpc/kernel/vmlinux.lds.S | 24 ++---------------------- > > 1 file changed, 2 insertions(+), 22 deletions(-) > > Acked-by: Michael Ellerman Thanks! > For the archives, Joel tried a similar patch a while back which caused > some problems, see: > > https://lore.kernel.org/linuxppc-dev/20190321003253.22100-1-joel@jms.id.au/ > > and a v2: > > https://lore.kernel.org/linuxppc-dev/20190329064453.12761-1-joel@jms.id.au/ > > This is similar to his v2. The only outstanding comment on his v2 was > from Segher: > (And I do not know if there are any tools that expect the notes in a phdr, > or even specifically the second phdr). > > But this patch solves that by not changing the note. Ah yes. Agreed: I'm retaining the note and dropping the workarounds. FWIW, this builds happily for me in my tests. -Kees -- Kees Cook