From: Greg KH <gregkh@linuxfoundation.org>
To: Chandra Annamaneni <chandra627@gmail.com>
Cc: devel@driverdev.osuosl.org, gneukum1@gmail.com,
michael.scheiderer@fau.de, fabian.krueger@fau.de,
linux-kernel@vger.kernel.org,
"Simon Sandström" <simon@nikanor.nu>,
"Dan Carpenter" <dan.carpenter@oracle.com>
Subject: Re: [PATCH 2/5] KPC2000: kpc2000_spi.c: Fix style issues (missing blank line)
Date: Fri, 11 Oct 2019 11:11:10 +0200 [thread overview]
Message-ID: <20191011091110.GA1124173@kroah.com> (raw)
In-Reply-To: <CAEge-i7Va8NrVGYzssFqvuGEwV=xPu9VL5_ZewXn2985QbEmcw@mail.gmail.com>
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Fri, Oct 11, 2019 at 02:02:32AM -0700, Chandra Annamaneni wrote:
> The first set of patches were in a single commit. I started from scratch
> and built these patches from 5 different commits. Don't know if the first
> set of patches are relevant anymore.
They are not relevant to being applied, but this patch series has
changed based on the comments you received from the previous patch(s).
So it is relevant to how you got to this set of patches.
This makes it easier for reviewers to understand what changed and what
they need to focus on, or ignore, in your new set of patches. This
isn't for you, it is for the people you are sending these patches to.
thanks,
greg k-h
next prev parent reply other threads:[~2019-10-11 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 5:51 [PATCH 1/5] KPC2000: kpc2000_spi.c: Fix style issues (line length) Chandra Annamaneni
2019-10-11 5:51 ` [PATCH 2/5] KPC2000: kpc2000_spi.c: Fix style issues (missing blank line) Chandra Annamaneni
2019-10-11 6:33 ` Greg KH
[not found] ` <CAEge-i7Va8NrVGYzssFqvuGEwV=xPu9VL5_ZewXn2985QbEmcw@mail.gmail.com>
2019-10-11 9:11 ` Greg KH [this message]
2019-10-11 5:51 ` [PATCH 3/5] KPC2000: kpc2000_spi.c: Fix style issues (misaligned brace) Chandra Annamaneni
2019-10-11 5:51 ` [PATCH 4/5] KPC2000: kpc2000_spi.c: Fix style issues (alignment) Chandra Annamaneni
2019-10-11 5:51 ` [PATCH 5/5] KPC2000: kpc2000_spi.c: Fix style issues (Unnecessary parenthesis) Chandra Annamaneni
2019-10-11 6:32 ` [PATCH 1/5] KPC2000: kpc2000_spi.c: Fix style issues (line length) Greg KH
2019-10-16 7:42 ` <Chandra Annamaneni>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011091110.GA1124173@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chandra627@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabian.krueger@fau.de \
--cc=gneukum1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.scheiderer@fau.de \
--cc=simon@nikanor.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).