From: Stefano Garzarella <sgarzare@redhat.com>
To: netdev@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org,
Jorgen Hansen <jhansen@vmware.com>,
"David S. Miller" <davem@davemloft.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Adit Ranadive <aditr@vmware.com>,
Jason Wang <jasowang@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net 1/2] vsock: add half-closed socket details in the implementation notes
Date: Fri, 11 Oct 2019 15:07:57 +0200 [thread overview]
Message-ID: <20191011130758.22134-2-sgarzare@redhat.com> (raw)
In-Reply-To: <20191011130758.22134-1-sgarzare@redhat.com>
vmci_transport never allowed half-closed socket on the host side.
Since we want to have the same behaviour across all transports, we
add a section in the "Implementation notes".
Cc: Jorgen Hansen <jhansen@vmware.com>
Cc: Adit Ranadive <aditr@vmware.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
net/vmw_vsock/af_vsock.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 2ab43b2bba31..27df57c2024b 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -83,6 +83,10 @@
* TCP_ESTABLISHED - connected
* TCP_CLOSING - disconnecting
* TCP_LISTEN - listening
+ *
+ * - Half-closed socket is supported only on the guest side. recv() on the host
+ * side should return EOF when the guest closes a connection, also if some
+ * data is still in the receive queue.
*/
#include <linux/types.h>
--
2.21.0
next prev parent reply other threads:[~2019-10-11 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 13:07 [PATCH net 0/2] vsock: don't allow half-closed socket in the host transports Stefano Garzarella
2019-10-11 13:07 ` Stefano Garzarella [this message]
2019-10-11 14:22 ` [PATCH net 1/2] vsock: add half-closed socket details in the implementation notes Michael S. Tsirkin
2019-10-11 14:37 ` Stefano Garzarella
2019-10-11 13:07 ` [PATCH net 2/2] vhost/vsock: don't allow half-closed socket in the host Stefano Garzarella
2019-10-11 14:26 ` Michael S. Tsirkin
2019-10-11 14:39 ` Stefano Garzarella
2019-10-11 14:19 ` [PATCH net 0/2] vsock: don't allow half-closed socket in the host transports Michael S. Tsirkin
2019-10-11 14:34 ` Stefano Garzarella
2019-10-12 22:38 ` Michael S. Tsirkin
2019-10-15 11:56 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011130758.22134-2-sgarzare@redhat.com \
--to=sgarzare@redhat.com \
--cc=aditr@vmware.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=jhansen@vmware.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).