From: Rob Herring <robh@kernel.org>
To: Talel Shenhar <talel@amazon.com>
Cc: maz@kernel.org, mark.rutland@arm.com, arnd@arndb.de,
bp@alien8.de, mchehab@kernel.org, james.morse@arm.com,
davem@davemloft.net, gregkh@linuxfoundation.org,
paulmck@linux.ibm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
dwmw@amazon.co.uk, benh@kernel.crashing.org, hhhawa@amazon.com,
ronenk@amazon.com, jonnyc@amazon.com, hanochu@amazon.com,
amirkl@amazon.com, barakw@amazon.com
Subject: Re: [PATCH v4 1/2] dt-bindings: edac: al-mc-edac: Amazon's Annapurna Labs Memory Controller EDAC
Date: Fri, 11 Oct 2019 08:29:04 -0500 [thread overview]
Message-ID: <20191011132904.GA15595@bogus> (raw)
In-Reply-To: <1570708454-10784-2-git-send-email-talel@amazon.com>
On Thu, Oct 10, 2019 at 02:54:13PM +0300, Talel Shenhar wrote:
> Document Amazon's Annapurna Labs Memory Controller EDAC SoC binding.
>
> Signed-off-by: Talel Shenhar <talel@amazon.com>
> ---
> .../bindings/edac/amazon,al-mc-edac.yaml | 50 ++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml
>
> diff --git a/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml b/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml
> new file mode 100644
> index 00000000..f66b094
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0
Forgot to mention, please make new bindings (GPL-2.0-only OR BSD-2-Clause).
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/edac/amazon,al-mc-edac.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amazon's Annapurna Labs Memory Controller EDAC
> +
> +maintainers:
> + - Talel Shenhar <talel@amazon.com>
> + - Talel Shenhar <talelshenhar@gmail.com>
> +
> +description: |
> + EDAC node is defined to describe on-chip error detection and correction for
> + Amazon's Annapurna Labs Memory Controller.
> +
> +properties:
> +
> + compatible:
> + const: amazon,al-mc-edac
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 2
> + items:
> + - description: uncorrectable error interrupt
> + - description: correctable error interrupt
> +
> + interrupt-names:
> + maxItems: 2
> + items:
> + - const: ue
> + - const: ce
Now the example fails to build:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.example.dt.yaml:
edac@f0080000: interrupt-names: ['ue'] is too short
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.example.dt.yaml:
edac@f0080000: interrupts: [[20, 4]] is too short
You either need to always have the CE irq or add 'minItems: 1' to both.
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + edac@f0080000 {
> + compatible = "amazon,al-mc-edac";
> + reg = <0x0 0xf0080000 0x0 0x00010000>;
> + interrupt-parent = <&amazon_al_system_fabric>;
> + interrupt-names = "ue";
> + interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
> + };
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-10-11 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 11:54 [PATCH v4 0/2] Amazon's Annapurna Labs Memory Controller EDAC Talel Shenhar
2019-10-10 11:54 ` [PATCH v4 1/2] dt-bindings: edac: al-mc-edac: " Talel Shenhar
2019-10-11 13:29 ` Rob Herring [this message]
2019-10-22 8:14 ` Shenhar, Talel
2019-10-10 11:54 ` [PATCH v4 2/2] EDAC: al-mc-edac: Introduce " Talel Shenhar
2019-10-11 8:23 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011132904.GA15595@bogus \
--to=robh@kernel.org \
--cc=amirkl@amazon.com \
--cc=arnd@arndb.de \
--cc=barakw@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mchehab@kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).