From: Lianbo Jiang <lijiang@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, x86@kernel.org, bhe@redhat.com, dyoung@redhat.com,
jgross@suse.com, dhowells@redhat.com, Thomas.Lendacky@amd.com,
ebiederm@xmission.com, vgoyal@redhat.com,
kexec@lists.infradead.org
Subject: [PATCH 0/3 v3] x86/kdump: Fix 'kmem -s' reported an invalid freepointer when SME was active
Date: Sat, 12 Oct 2019 10:21:37 +0800 [thread overview]
Message-ID: <20191012022140.19003-1-lijiang@redhat.com> (raw)
In purgatory(), the main things are as below:
[1] verify sha256 hashes for various segments.
Lets keep these codes, and do not touch the logic.
[2] copy the first 640k content to a backup region.
Lets safely remove it and clean all code related to backup region.
This patch series will remove the backup region, because the current
handling of copying the first 640k runs into problems when SME is
active.
The low 1MiB region will always be reserved when the crashkernel kernel
command line option is specified. And this way makes it unnecessary to
do anything with the low 1MiB region, because the memory allocated later
won't fall into the low 1MiB area.
This series includes three patches:
[1] Fix 'kmem -s' reported an invalid freepointer when SME was active
The low 1MiB region will always be reserved when the crashkernel
kernel command line option is specified, which ensures that the
memory allocated later won't fall into the low 1MiB area.
[2] x86/kdump cleanup: remove the unused crash_copy_backup_region()
The crash_copy_backup_region() has never been used, so clean
up the redundant code.
[3] x86/kdump: clean up all the code related to the backup region
Remove the backup region and clean up.
Changes since v1:
[1] Add extra checking condition: when the crashkernel option is
specified, reserve the low 640k area.
Changes since v2:
[1] Reserve the low 1MiB region when the crashkernel option is only
specified.(Suggested by Eric)
[2] Remove the unused crash_copy_backup_region()
[3] Remove the backup region and clean up
[4] Split them into three patches
Lianbo Jiang (3):
x86/kdump: Fix 'kmem -s' reported an invalid freepointer when SME was
active
x86/kdump cleanup: remove the unused crash_copy_backup_region()
x86/kdump: clean up all the code related to the backup region
arch/x86/include/asm/crash.h | 1 -
arch/x86/include/asm/kexec.h | 10 ----
arch/x86/include/asm/purgatory.h | 10 ----
arch/x86/kernel/crash.c | 91 ++++++------------------------
arch/x86/kernel/machine_kexec_64.c | 47 ---------------
arch/x86/purgatory/purgatory.c | 19 -------
arch/x86/realmode/init.c | 11 ++++
7 files changed, 27 insertions(+), 162 deletions(-)
--
2.17.1
next reply other threads:[~2019-10-12 2:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 2:21 Lianbo Jiang [this message]
2019-10-12 2:21 ` [PATCH 1/3 v3] x86/kdump: Fix 'kmem -s' reported an invalid freepointer when SME was active Lianbo Jiang
2019-10-12 2:21 ` [PATCH 2/3 v3] x86/kdump cleanup: remove the unused crash_copy_backup_region() Lianbo Jiang
2019-10-12 2:21 ` [PATCH 3/3 v3] x86/kdump: clean up all the code related to the backup region Lianbo Jiang
2019-10-12 11:26 ` Eric W. Biederman
2019-10-12 12:16 ` Dave Young
2019-10-13 3:54 ` Eric W. Biederman
2019-10-13 9:36 ` lijiang
2019-10-15 11:04 ` Eric W. Biederman
2019-10-16 8:40 ` lijiang
2019-10-16 14:30 ` lijiang
2019-10-16 16:51 ` Eric W. Biederman
2019-10-13 10:20 ` Dave Young
2019-10-14 10:02 ` lijiang
2019-10-15 11:11 ` Eric W. Biederman
2019-10-16 3:24 ` lijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012022140.19003-1-lijiang@redhat.com \
--to=lijiang@redhat.com \
--cc=Thomas.Lendacky@amd.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dhowells@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).