linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: rui.zhang@intel.com, edubezval@gmail.com
Cc: daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org,
	amit.kucheria@linaro.org
Subject: [PATCH 07/11] thermal: Move get_thermal_instance to the internal header
Date: Sat, 12 Oct 2019 08:52:51 +0200	[thread overview]
Message-ID: <20191012065255.23249-7-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20191012065255.23249-1-daniel.lezcano@linaro.org>

The function is not used in other place than the thermal directory. It
does not make sense to export its definition in the global header as
there is no use of it.

Move its the definition in the internal header and allow better
self-encapsulation.

Take the opportunity to add the parameter names to make checkpatch
happy and remove the pointless stubs.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/thermal_core.h | 5 +++++
 include/linux/thermal.h        | 6 ------
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
index c03a07164ca7..c75309d858ce 100644
--- a/drivers/thermal/thermal_core.h
+++ b/drivers/thermal/thermal_core.h
@@ -76,6 +76,11 @@ void thermal_zone_set_trips(struct thermal_zone_device *tz);
 
 int get_tz_trend(struct thermal_zone_device *tz, int trip);
 
+struct thermal_instance *
+get_thermal_instance(struct thermal_zone_device *tz,
+		     struct thermal_cooling_device *cdev,
+		     int trip);
+
 /*
  * This structure is used to describe the behavior of
  * a certain cooling device on a certain trip point
diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index a87f551d114d..4436addc0e83 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -415,8 +415,6 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp);
 int thermal_zone_get_slope(struct thermal_zone_device *tz);
 int thermal_zone_get_offset(struct thermal_zone_device *tz);
 
-struct thermal_instance *get_thermal_instance(struct thermal_zone_device *,
-		struct thermal_cooling_device *, int);
 void thermal_cdev_update(struct thermal_cooling_device *);
 void thermal_notify_framework(struct thermal_zone_device *, int);
 #else
@@ -474,10 +472,6 @@ static inline int thermal_zone_get_offset(
 		struct thermal_zone_device *tz)
 { return -ENODEV; }
 
-static inline struct thermal_instance *
-get_thermal_instance(struct thermal_zone_device *tz,
-	struct thermal_cooling_device *cdev, int trip)
-{ return ERR_PTR(-ENODEV); }
 static inline void thermal_cdev_update(struct thermal_cooling_device *cdev)
 { }
 static inline void thermal_notify_framework(struct thermal_zone_device *tz,
-- 
2.17.1


  parent reply	other threads:[~2019-10-12  6:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-12  6:52 [PATCH 01/11] thermal: Move default governor config option to the internal header Daniel Lezcano
2019-10-12  6:52 ` [PATCH 02/11] thermal: Move struct thermal_attr to the private header Daniel Lezcano
2019-10-12  6:52 ` [PATCH 03/11] thermal: Move internal IPA functions Daniel Lezcano
2019-10-12  6:52 ` [PATCH 04/11] thermal: Move trip point structure definition to private header Daniel Lezcano
2019-10-12  6:52 ` [PATCH 05/11] thermal: Move set_trips function to the internal header Daniel Lezcano
2019-10-14 14:32   ` Amit Kucheria
2019-10-12  6:52 ` [PATCH 06/11] thermal: Move get_tz_trend " Daniel Lezcano
2019-10-12  6:52 ` Daniel Lezcano [this message]
2019-10-12  6:52 ` [PATCH 08/11] thermal: Change IS_ENABLED to IFDEF in the header file Daniel Lezcano
2019-10-12  6:52 ` [PATCH 09/11] thermal: Remove stubs for thermal_zone_[un]bind_cooling_device Daniel Lezcano
2019-10-12  6:52 ` [PATCH 10/11] thermal: Remove thermal_zone_device_update() stub Daniel Lezcano
2019-10-12  6:52 ` [PATCH 11/11] thermal: Move thermal governor structure to internal header Daniel Lezcano
2019-10-14  7:48   ` kbuild test robot
2019-10-14  9:54   ` kbuild test robot
2019-10-14 14:32   ` Amit Kucheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191012065255.23249-7-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=amit.kucheria@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).