From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40366C4CECE for ; Mon, 14 Oct 2019 07:37:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19A6D20673 for ; Mon, 14 Oct 2019 07:37:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729255AbfJNHh0 (ORCPT ); Mon, 14 Oct 2019 03:37:26 -0400 Received: from mga04.intel.com ([192.55.52.120]:38678 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728606AbfJNHh0 (ORCPT ); Mon, 14 Oct 2019 03:37:26 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Oct 2019 00:37:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,295,1566889200"; d="scan'208";a="194153559" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga008.fm.intel.com with ESMTP; 14 Oct 2019 00:37:21 -0700 Received: from andy by smile with local (Exim 4.92.2) (envelope-from ) id 1iJuuu-0002pv-EG; Mon, 14 Oct 2019 10:37:20 +0300 Date: Mon, 14 Oct 2019 10:37:20 +0300 From: Andy Shevchenko To: Dmitry Torokhov Cc: "Rafael J. Wysocki" , Heikki Krogerus , Mika Westerberg , Linus Walleij , Ard Biesheuvel , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v5 10/14] software node: rename is_array to is_inline Message-ID: <20191014073720.GH32742@smile.fi.intel.com> References: <20191011230721.206646-1-dmitry.torokhov@gmail.com> <20191011230721.206646-11-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191011230721.206646-11-dmitry.torokhov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 11, 2019 at 04:07:17PM -0700, Dmitry Torokhov wrote: > We do not need a special flag to know if we are dealing with an array, > as we can get that data from ratio between element length and the data > size, however we do need a flag to know whether the data is stored > directly inside property_entry or separately. > - if (prop->is_array) > + if (!prop->is_inline) > - if (p->is_array) { > + if (!p->is_inline) { > - if (src->is_array) { > + if (!src->is_inline) { May we have positive conditionals instead? > + * @is_inline: True when the property value is stored directly in I think word 'directly' is superfluous here. Or, perhaps, 'stored directly' -> 'embedded' > + * &struct property_entry instance. > + * @pointer: Pointer to the property when it is stored separately from > + * the &struct property_entry instance. 'separately from' -> 'outside' ? > + * @value: Value of the property when it is stored inline. 'stored inline' -> 'embedded in the &struct...' ? -- With Best Regards, Andy Shevchenko