From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C42F5ECE587 for ; Mon, 14 Oct 2019 09:16:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9407420659 for ; Mon, 14 Oct 2019 09:16:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="b4CjXUha" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730738AbfJNJQk (ORCPT ); Mon, 14 Oct 2019 05:16:40 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:39041 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730691AbfJNJQj (ORCPT ); Mon, 14 Oct 2019 05:16:39 -0400 Received: by mail-ed1-f65.google.com with SMTP id a15so14151362edt.6 for ; Mon, 14 Oct 2019 02:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=d8Jpp+ZNyeMIECLhU8stIu5ojWvnBY0aBAMY/MpsQ2k=; b=b4CjXUhaDh5V5oSXdLp/N67GUtShbU8b5VZIcqzq+wEro6yUGpwdYVnICq9N5M6nhJ LlieGbgdTyq7BMwUYDZ/uzN6u+XXNRaLJp9Idz+cgPdc5xMZWiR8EtNKrhuJvWyTvI+H JBxzlPf6+MC9ADl4y7sVAeie/ybms+opGMWy4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=d8Jpp+ZNyeMIECLhU8stIu5ojWvnBY0aBAMY/MpsQ2k=; b=CsEffUM/Jl3bTrdqVhCaKc0Wg4zckCZ6fWILE2khnr6DZwqwYnCLCLKAsWvfa0XM4W h8afK0iCXJbhaTm+ECq558HBQfNVn8Iy6kk2sjqqOt2GZuEDqdOr9Dy2z5pDqgIP1Vu2 0eMI98V4xMatGYntxfQF0/exXjdqI/9d/TpUKikNCbs9k1UA6kIXVehNxF3HgS5mvrt9 g2Ik5LP8JtcymTKX/55qiEiJAR0R3687q0e6MEj+Uj4hc+jBqoVyHaMXWLHfc2hjgcX4 4/xUmD5MwYVarG+MSDYDwumB37pScQXwF4e7DsryncsOecUbgHgCM7R3Xyhpm+OewSQ5 E9/Q== X-Gm-Message-State: APjAAAV+uNxUIPgTnqn4+TNJn/MD4SCtWe5lv/gm2izbwYkp+waLYsa+ Ebr9YOHQFlM9cPFvvcjkbcBOdQ== X-Google-Smtp-Source: APXvYqzV5ULbBVu4tlr7KIdPTRWorn11s+O/SdFjTBjSfIeo8Hcbdl95adE/jj1Lg/k1T3ENwiaOhg== X-Received: by 2002:aa7:c556:: with SMTP id s22mr27059909edr.105.1571044598174; Mon, 14 Oct 2019 02:16:38 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id gx14sm2239181ejb.38.2019.10.14.02.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 02:16:37 -0700 (PDT) Date: Mon, 14 Oct 2019 11:16:35 +0200 From: Daniel Vetter To: syzbot Cc: airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, syzkaller-bugs@googlegroups.com Subject: Re: WARNING in drm_mode_createblob_ioctl Message-ID: <20191014091635.GI11828@phenom.ffwll.local> Mail-Followup-To: syzbot , airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, syzkaller-bugs@googlegroups.com References: <000000000000b2de3a0594d8b4ca@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000000000000b2de3a0594d8b4ca@google.com> X-Operating-System: Linux phenom 5.2.0-2-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 13, 2019 at 11:09:09PM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit: 8ada228a Add linux-next specific files for 20191011 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1423a87f600000 > kernel config: https://syzkaller.appspot.com/x/.config?x=7cf4eed5fe42c31a > dashboard link: https://syzkaller.appspot.com/bug?extid=fb77e97ebf0612ee6914 > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > Unfortunately, I don't have any reproducer for this crash yet. Hm only thing that could go wrong is how we allocate the target for the user_copy, which is an argument directly from the ioctl parameter struct. Does syzbot not track that? We use the standard linux ioctl struct encoding in drm. Otherwise I have no idea why it can't create a reliable reproducer for this ... I'm also not seeing the bug, all the input validation we have seems correct :-/ -Daniel > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > Reported-by: syzbot+fb77e97ebf0612ee6914@syzkaller.appspotmail.com > > ------------[ cut here ]------------ > WARNING: CPU: 1 PID: 30449 at include/linux/thread_info.h:150 > check_copy_size include/linux/thread_info.h:150 [inline] > WARNING: CPU: 1 PID: 30449 at include/linux/thread_info.h:150 copy_from_user > include/linux/uaccess.h:143 [inline] > WARNING: CPU: 1 PID: 30449 at include/linux/thread_info.h:150 > drm_mode_createblob_ioctl+0x398/0x490 drivers/gpu/drm/drm_property.c:800 > Kernel panic - not syncing: panic_on_warn set ... > CPU: 1 PID: 30449 Comm: syz-executor.5 Not tainted 5.4.0-rc2-next-20191011 > #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > Google 01/01/2011 > Call Trace: > __dump_stack lib/dump_stack.c:77 [inline] > dump_stack+0x172/0x1f0 lib/dump_stack.c:113 > panic+0x2e3/0x75c kernel/panic.c:221 > __warn.cold+0x2f/0x35 kernel/panic.c:582 > report_bug+0x289/0x300 lib/bug.c:195 > fixup_bug arch/x86/kernel/traps.c:174 [inline] > fixup_bug arch/x86/kernel/traps.c:169 [inline] > do_error_trap+0x11b/0x200 arch/x86/kernel/traps.c:267 > do_invalid_op+0x37/0x50 arch/x86/kernel/traps.c:286 > invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1028 > RIP: 0010:check_copy_size include/linux/thread_info.h:150 [inline] > RIP: 0010:copy_from_user include/linux/uaccess.h:143 [inline] > RIP: 0010:drm_mode_createblob_ioctl+0x398/0x490 > drivers/gpu/drm/drm_property.c:800 > Code: c1 ea 03 80 3c 02 00 0f 85 ed 00 00 00 49 89 5d 00 e8 3c 28 cb fd 4c > 89 f7 e8 64 92 9e 03 31 c0 e9 75 fd ff ff e8 28 28 cb fd <0f> 0b e8 21 28 cb > fd 4d 85 e4 b8 f2 ff ff ff 0f 84 5b fd ff ff 89 > RSP: 0018:ffff8880584efaa8 EFLAGS: 00010246 > RAX: 0000000000040000 RBX: ffff8880a3a90000 RCX: ffffc900109da000 > RDX: 0000000000040000 RSI: ffffffff83a7eaf8 RDI: 0000000000000007 > RBP: ffff8880584efae8 R08: ffff888096c40080 R09: ffffed1014752110 > R10: ffffed101475210f R11: ffff8880a3a9087f R12: ffffc90014907000 > R13: ffff888028aa0000 R14: 000000009a6c7969 R15: ffffc90014907058 > > > --- > This bug is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkaller@googlegroups.com. > > syzbot will keep track of this bug report. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch