From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: scott.branden@broadcom.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, phil@raspberrypi.org,
jonathan@raspberrypi.org, matthias.bgg@kernel.org,
linux-rpi-kernel@lists.infradead.org, wahrenst@gmx.net,
nsaenzjulienne@suse.de, opendmb@gmail.com,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: bcmgenet: Generate a random MAC if none is valid
Date: Tue, 15 Oct 2019 17:04:59 -0700 (PDT) [thread overview]
Message-ID: <20191015.170459.2090609203514838368.davem@davemloft.net> (raw)
In-Reply-To: <20191015153955.2e602903@cakuba.netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue, 15 Oct 2019 15:39:55 -0700
> On Tue, 15 Oct 2019 15:32:28 -0700, Scott Branden wrote:
>> > @@ -3482,7 +3476,12 @@ static int bcmgenet_probe(struct platform_device *pdev)
>> >
>> > SET_NETDEV_DEV(dev, &pdev->dev);
>> > dev_set_drvdata(&pdev->dev, dev);
>> > - ether_addr_copy(dev->dev_addr, macaddr);
>> > + if (IS_ERR_OR_NULL(macaddr) || !is_valid_ether_addr(macaddr)) {
>> > + dev_warn(&pdev->dev, "using random Ethernet MAC\n");
>>
>> I would still consider this warrants a dev_err as you should not be
>> using the device with a random MAC address assigned to it. But I'll
>> leave it to the "experts" to decide on the print level here.
>
> FWIW I'd stick to warn for this message since this is no longer a hard
> failure.
Agreed.
next prev parent reply other threads:[~2019-10-16 0:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 21:20 [PATCH net-next v2] net: bcmgenet: Generate a random MAC if none is valid Florian Fainelli
2019-10-15 0:52 ` Doug Berger
2019-10-15 22:32 ` Scott Branden
2019-10-15 22:39 ` Jakub Kicinski
2019-10-16 0:04 ` David Miller [this message]
2019-10-16 3:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015.170459.2090609203514838368.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jonathan@raspberrypi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=matthias.bgg@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=opendmb@gmail.com \
--cc=phil@raspberrypi.org \
--cc=scott.branden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).