linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tuowen Zhao <ztuowen@gmail.com>
Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org,
	AceLan Kao <acelan.kao@canonical.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc
Date: Tue, 15 Oct 2019 10:44:34 +0300	[thread overview]
Message-ID: <20191015074434.GU32742@smile.fi.intel.com> (raw)
In-Reply-To: <c4bcdf14e0a60a679429eebd439b2380d97dafe9.camel@gmail.com>

On Mon, Oct 14, 2019 at 01:15:53PM -0600, Tuowen Zhao wrote:
> On Tue, 2019-10-15 at 02:46 +0800, kbuild test robot wrote:
> > -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> >         GCC_VERSION=7.4.0 make.cross ARCH=sparc64 
> 
> Oops, I'm not sure how would we best fix this. Clearly the patch is not
> intended for sparc64. Maybe adding devm_ioremap_uc is rather not safe
> right now.

It seems you need a preparatory patch to satisfy sparc64.

> Although, We could declare dummies for these architectures like it has
> been for powerpc.
> 
> I just noticed another driver having this issue, and fixed with direct
> calls to ioremap_uc().
> 
> 3cc2dac5be3f2: drivers/video/fbdev/atyfb: Replace MTRR UC hole with
> strong UC

That's why I asked Luis to have a look at this :)

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2019-10-15  7:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 15:33 [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc Tuowen Zhao
2019-10-14 15:33 ` [PATCH v4 2/2] mfd: intel-lpss: use devm_ioremap_uc for MMIO Tuowen Zhao
2019-10-14 18:46 ` [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc kbuild test robot
2019-10-14 19:15   ` Tuowen Zhao
2019-10-15  7:44     ` Andy Shevchenko [this message]
2019-10-16 12:56       ` Luis Chamberlain
2019-10-16 17:58         ` Tuowen Zhao
2019-12-04 11:32 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191015074434.GU32742@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=acelan.kao@canonical.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=ztuowen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).