From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83C98C10F14 for ; Tue, 15 Oct 2019 12:54:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 566BB217F9 for ; Tue, 15 Oct 2019 12:54:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="MGSIhRKC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728703AbfJOMyH (ORCPT ); Tue, 15 Oct 2019 08:54:07 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:45578 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbfJOMyG (ORCPT ); Tue, 15 Oct 2019 08:54:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mSm5WrnMjVEX7H9gawcWAyy7zSXN5kf0ISdm/U6OHfU=; b=MGSIhRKC4Jdh5LmqSfqDt1n1JI yaWDaYDy1m0gmiCd1H1KCGaPTLqhKh5fcJ4fHvU4uCdAMsYXm9LfGt7R8nQw9LYRoA4hK3d+B8XKF Mwt4lNYURQcVWzUBYr1t6alAM2GE2DAVS8Qe7bI9xBhpUdo43vjYKKlqbcyMnCzmsAlY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iKMKw-00014w-He; Tue, 15 Oct 2019 14:54:02 +0200 Date: Tue, 15 Oct 2019 14:54:02 +0200 From: Andrew Lunn To: Dmitry Torokhov Cc: Linus Walleij , netdev@vger.kernel.org, "David S . Miller" , linux-kernel@vger.kernel.org, Florian Fainelli , Heiner Kallweit Subject: Re: [PATCH v2 2/3] net: phy: fixed_phy: fix use-after-free when checking link GPIO Message-ID: <20191015125402.GB3486@lunn.ch> References: <20191014174022.94605-1-dmitry.torokhov@gmail.com> <20191014174022.94605-3-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191014174022.94605-3-dmitry.torokhov@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 14, 2019 at 10:40:21AM -0700, Dmitry Torokhov wrote: > If we fail to locate GPIO for any reason other than deferral or > not-found-GPIO, we try to print device tree node info, however if might > be freed already as we called of_node_put() on it. > > Acked-by: David S. Miller > Signed-off-by: Dmitry Torokhov Reviewed-by: Andrew Lunn Andrew