From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE08C10F14 for ; Tue, 15 Oct 2019 17:04:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E0F12084B for ; Tue, 15 Oct 2019 17:04:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="keQCmIX4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727388AbfJOREF (ORCPT ); Tue, 15 Oct 2019 13:04:05 -0400 Received: from mail.skyhub.de ([5.9.137.197]:57978 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbfJOREE (ORCPT ); Tue, 15 Oct 2019 13:04:04 -0400 Received: from zn.tnic (p200300EC2F157800C5C9C957E5FD72EA.dip0.t-ipconnect.de [IPv6:2003:ec:2f15:7800:c5c9:c957:e5fd:72ea]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D2DDD1EC0C9F; Tue, 15 Oct 2019 19:04:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1571159043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=qR2t1iMXW4bUkgiQHzxnZJRfCBt9ULeZhd361Oh91pM=; b=keQCmIX4iS+qq8uKycuIVqAST76xg3kWFU4/8cCFLfflrjthTRHzcbl9pfV2yUY3Z+g+me 2dqXPBoTwBHVrtlH8YYs2M0+UuiweCN6CoRMXkOZBL/9A7TaZgFfNaRJKqF4udkGSRC0IC 4tmbiZB6VrAtSi09rCTx5wQd17tivWI= Date: Tue, 15 Oct 2019 19:03:58 +0200 From: Borislav Petkov To: Jiri Slaby Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 15/28] x86/asm/purgatory: Start using annotations Message-ID: <20191015170358.GE596@zn.tnic> References: <20191011115108.12392-1-jslaby@suse.cz> <20191011115108.12392-16-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191011115108.12392-16-jslaby@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 11, 2019 at 01:50:55PM +0200, Jiri Slaby wrote: > Purgatory used no annotations at all. So include linux/linkage.h and > annotate everything: > * code by SYM_CODE_* > * data by SYM_DATA_* > > Signed-off-by: Jiri Slaby > Cc: Borislav Petkov > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > --- > arch/x86/purgatory/entry64.S | 21 ++++++++++++--------- > arch/x86/purgatory/setup-x86_64.S | 14 ++++++++------ > arch/x86/purgatory/stack.S | 7 ++++--- > 3 files changed, 24 insertions(+), 18 deletions(-) ... > @@ -75,12 +76,12 @@ r13: .quad 0x0 > r14: .quad 0x0 > r15: .quad 0x0 > rip: .quad 0x0 > - .size entry64_regs, . - entry64_regs > +SYM_DATA_END(entry64_regs) > > /* GDT */ > .section ".rodata" > .balign 16 > -gdt: > +SYM_DATA_START_LOCAL(gdt) > /* 0x00 unusable segment Note for the applier: Fixup that comment: /* * 0x00 ... * ... > * 0x08 unused > * so use them as gdt ptr -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette