From: Eric Biggers <ebiggers@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
David Howells <dhowells@redhat.com>,
linux-fsdevel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: fsmount: add missing mntget()
Date: Tue, 15 Oct 2019 17:52:32 -0700 [thread overview]
Message-ID: <20191016005232.GA726@sol.localdomain> (raw)
In-Reply-To: <20190710003113.GC17978@ZenIV.linux.org.uk>
On Wed, Jul 10, 2019 at 01:31:13AM +0100, Al Viro wrote:
> On Tue, Jul 09, 2019 at 04:00:29PM -0700, Eric Biggers wrote:
>
> > > index 49a058c73e4c..26f74e092bd9 100644
> > > --- a/fs/pnode.h
> > > +++ b/fs/pnode.h
> > > @@ -44,7 +44,7 @@ int propagate_mount_busy(struct mount *, int);
> > > void propagate_mount_unlock(struct mount *);
> > > void mnt_release_group_id(struct mount *);
> > > int get_dominating_id(struct mount *mnt, const struct path *root);
> > > -unsigned int mnt_get_count(struct mount *mnt);
> > > +int mnt_get_count(struct mount *mnt);
> > > void mnt_set_mountpoint(struct mount *, struct mountpoint *,
> > > struct mount *);
> > > void mnt_change_mountpoint(struct mount *parent, struct mountpoint *mp,
> >
> > Miklos, are you planning to send this as a formal patch?
>
> Hold it for a while, OK? There's an unpleasant issue (a very long-standing
> one) with boxen that have an obscene amount of RAM. Some of the counters
> involved will need to become long. This is the coming cycle fodder (mounts
> and inodes are relatively easy; it's dentry->d_count that brings arseloads
> of fun) and I'd rather deal with that sanity check as part of the same series.
> It's not forgotten... Patch series re limiting the number of negative
> dentries is also getting into the same mix. Watch #work.dcache - what's
> in there is basically prep work for the big pile for the next cycle; it'll
> be interesting...
Al, whatever happened to the refcounting patches you mentioned here?
- Eric
next prev parent reply other threads:[~2019-10-16 0:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 13:54 "Dentry still in use" splats in v5.2-rc3 Mark Rutland
2019-06-10 18:30 ` Eric Biggers
2019-06-12 18:43 ` [PATCH] vfs: fsmount: add missing mntget() Eric Biggers
2019-06-13 8:47 ` Miklos Szeredi
2019-06-13 16:41 ` Eric Biggers
2019-07-09 23:00 ` Eric Biggers
2019-07-10 0:31 ` Al Viro
2019-10-16 0:52 ` Eric Biggers [this message]
2019-06-13 9:03 ` Mark Rutland
2019-06-17 21:34 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016005232.GA726@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).