From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9641ECE599 for ; Wed, 16 Oct 2019 07:06:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 965712082C for ; Wed, 16 Oct 2019 07:06:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lXI1+nMF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389343AbfJPHGl (ORCPT ); Wed, 16 Oct 2019 03:06:41 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:41636 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387777AbfJPHGl (ORCPT ); Wed, 16 Oct 2019 03:06:41 -0400 Received: by mail-wr1-f67.google.com with SMTP id p4so10773408wrm.8; Wed, 16 Oct 2019 00:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fy0Igawx+eGgGntcbgCob/Oi3WyPHOBuVYeVnj6J198=; b=lXI1+nMFTpbZQCJE2YZmWssTNO/Cd6w7JlpW5EEU5S+fG64Xs+A4c/IIfvcBUYfkR8 HBbHuB8GjnQffMSBUl/lDHqdvIzYd1rTCG7mz1SoEJlnWURct9NLPukqgib9FBt1qtHw uaFnTc8mWZvLN/Z93b/L6QW7g7UV6/e9cRdDk10om+BoqCNOjYazgs4jTexpdI7oW4w0 w+ZUh+qUVpI9Z+bmlXOi+5iDGjdGBQfWgYXHeRKWH/r7uPnci16jcYE0+yzCBJe4mzd0 TNPfsWOY2wVuKUprhPysbFhcXZfY4MZYQz9I4nQZqaG/BcyOpkC7AZGfmxCu8NzG5yTc D5Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fy0Igawx+eGgGntcbgCob/Oi3WyPHOBuVYeVnj6J198=; b=C/L3mi8+ZlCiaGrHhSMke+7RozeiAkppJYObEv0akrvHGCxW+aVznUsW8dByivOBlq +/27VHeJPNOPeJqhSjpEf+wr3Z5qeh7xvPc0G4ECdWebHCLx8icoPSQXemI/dBLQmtRW JKqEnZck9nUrkEpLgdJtRWKobUxd0ZIbWFdwskcw1RdnuQn8JLrz2lJa4e5facx6cgRr YwF4Ujszwg+LOou5SHdrMlihbPq5xj+9p7LvaTa4OsWMyIlJXjY9TZh4A7KW5AjJmYkt 51JAIj4AEaFKFi6wvr94X39MORhAXLs7ZBQbHTRNm9lEw9Wz/x/vMIa7/2SjpHHFmFEl ncVg== X-Gm-Message-State: APjAAAWbyyLhhVZsDIg1iafLvRl7bdGXlt00a+u7iarA0eXAiCeOfm+e oPoqOhK9Ojiao2dJCmgZw/Gi5jCp X-Google-Smtp-Source: APXvYqw6N0t13E+81VszyfgVqlQlypn9E08dVdeUj2+xS1aYERza5WnnIUhPE6yvc0WBX33f37mjCg== X-Received: by 2002:adf:cd8d:: with SMTP id q13mr1298032wrj.103.1571209597634; Wed, 16 Oct 2019 00:06:37 -0700 (PDT) Received: from localhost (p2E5BE2CE.dip0.t-ipconnect.de. [46.91.226.206]) by smtp.gmail.com with ESMTPSA id n22sm1531230wmk.19.2019.10.16.00.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 00:06:36 -0700 (PDT) Date: Wed, 16 Oct 2019 09:06:35 +0200 From: Thierry Reding To: Fabrice Gasnier Cc: robh+dt@kernel.org, u.kleine-koenig@pengutronix.de, alexandre.torgue@st.com, mark.rutland@arm.com, mcoquelin.stm32@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, benjamin.gaignard@st.com, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v2 3/3] pwm: stm32: add power management support Message-ID: <20191016070635.GC1296874@ulmo> References: <1570193633-6600-1-git-send-email-fabrice.gasnier@st.com> <1570193633-6600-4-git-send-email-fabrice.gasnier@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QRj9sO5tAVLaXnSD" Content-Disposition: inline In-Reply-To: <1570193633-6600-4-git-send-email-fabrice.gasnier@st.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --QRj9sO5tAVLaXnSD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 04, 2019 at 02:53:53PM +0200, Fabrice Gasnier wrote: > Add suspend/resume PM sleep ops. When going to low power, enforce the PWM > channel isn't active. Let the PWM consumers disable it during their own > suspend sequence, see [1]. So, perform a check here, and handle the > pinctrl states. Also restore the break inputs upon resume, as registers > content may be lost when going to low power mode. >=20 > [1] https://lkml.org/lkml/2019/2/5/770 >=20 > Signed-off-by: Fabrice Gasnier > --- > Changes in v2: > Follow Uwe suggestions/remarks: > - Add a precursor patch to ease reviewing > - Use registers read instead of pwm_get_state > - Add a comment to mention registers content may be lost in low power mode > --- > drivers/pwm/pwm-stm32.c | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) Applied, thanks. I made two minor changes, though, see below. >=20 > diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c > index cf8658c..546b661 100644 > --- a/drivers/pwm/pwm-stm32.c > +++ b/drivers/pwm/pwm-stm32.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > =20 > @@ -655,6 +656,42 @@ static int stm32_pwm_remove(struct platform_device *= pdev) > return 0; > } > =20 > +static int __maybe_unused stm32_pwm_suspend(struct device *dev) > +{ > + struct stm32_pwm *priv =3D dev_get_drvdata(dev); > + unsigned int ch; I renamed this to just "i", which is more idiomatic for loop variables. The function is small enough not to need to differentiate between loop variables. > + u32 ccer, mask; > + > + /* Look for active channels */ > + ccer =3D active_channels(priv); > + > + for (ch =3D 0; ch < priv->chip.npwm; ch++) { > + mask =3D TIM_CCER_CC1E << (ch * 4); > + if (ccer & mask) { > + dev_err(dev, "The consumer didn't stop us (%s)\n", > + priv->chip.pwms[ch].label); Changed this to: "PWM %u still in use by consumer %s\n", i, priv->chip.pwms[i].label I think that might help clarify which PWM is still enabled in case the consumers don't set a label. Thierry > + return -EBUSY; > + } > + } > + > + return pinctrl_pm_select_sleep_state(dev); > +} > + > +static int __maybe_unused stm32_pwm_resume(struct device *dev) > +{ > + struct stm32_pwm *priv =3D dev_get_drvdata(dev); > + int ret; > + > + ret =3D pinctrl_pm_select_default_state(dev); > + if (ret) > + return ret; > + > + /* restore breakinput registers that may have been lost in low power */ > + return stm32_pwm_apply_breakinputs(priv); > +} > + > +static SIMPLE_DEV_PM_OPS(stm32_pwm_pm_ops, stm32_pwm_suspend, stm32_pwm_= resume); > + > static const struct of_device_id stm32_pwm_of_match[] =3D { > { .compatible =3D "st,stm32-pwm", }, > { /* end node */ }, > @@ -667,6 +704,7 @@ static struct platform_driver stm32_pwm_driver =3D { > .driver =3D { > .name =3D "stm32-pwm", > .of_match_table =3D stm32_pwm_of_match, > + .pm =3D &stm32_pwm_pm_ops, > }, > }; > module_platform_driver(stm32_pwm_driver); > --=20 > 2.7.4 >=20 --QRj9sO5tAVLaXnSD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl2mwXsACgkQ3SOs138+ s6GqmQ//aMbyiuKupfEKiM3NlzeTFHoXGDg+k4W+S9nTP9R1XcCo+LUn9otYurGO f44vih/M5jOuxA1RJ3w3Ji1fFOLD4/QXpTCN1nf+E1U0E/wo8HuPjpPJsZGj3vEJ YeLxDNmpVe/VID1GKuyACOChqCI0dSvMmZYqbKMSSRhUVNmfja/FnubM6iCQ8xzY qqUDkr4R1OCc4EjB9h5L+uBb+vy6iwGxEIZZNuMn3khiVvNTZpiI0D5qGLC0eVLM 3pDe6BTs/B7sI6OgQ2EJjqne9CbYXT3j/ANty3k4NcPXnMZ2nJT+8anoczxo2ZwB zyA5SzMctvcCHNpqrbAZLuOPERTA//X8BisEzJ9YRC1WjKuvJ9ykyXWWtcEnYdyr JeS6NNslrxDC1Fl4mrJV4rEJqm01giH2Pz1J0+8FAYYiga9QYQoYqjjxos6NSxde PcruGHt6xLWd647jwNGDrrG1G8gz+7xUEVpyHD8xSVXsNZ41Rst3WSkmwmu0vr4Y S7y5ylK/O9SW9p3yhyVuQPCc0rk/Mgln4BnOj8jq0FQDNVFosnC0eKX3tI8/CWlB Mpe9Rc7W4v3Hr7GBXoNqbNx4Uudfg7exBCc0pk2LFrobvyyjy+1vmKPtW6HnH4k3 S6h+dAMVH0QFmOimR8+QXtzTSUQ3ik96+Na4q+C44ozzuX/EBNs= =+BC6 -----END PGP SIGNATURE----- --QRj9sO5tAVLaXnSD--