From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2897DECE599 for ; Wed, 16 Oct 2019 22:19:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8253207FF for ; Wed, 16 Oct 2019 22:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571264387; bh=/nAysgjTFmewi/5K89zTSe8m+NSh6ZbHkmJVyj9QHAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NlvbkqMKTz4m5tngNC8ORY6xUkTu2RO9wbbyW76kdnft0morC9xpHmmlWuRPwWdRw GNZ/gZQ2ylGsm+VFqh8tHDbaLUPshz9TXcJV5IVyaMR5EbtLz2X1TUAePIE7vFM1/2 Q+7HjHCi1g2sxILrpMY7It+3SzEEqHIC+E0rT/Hk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405629AbfJPWTp (ORCPT ); Wed, 16 Oct 2019 18:19:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:43514 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437637AbfJPVyB (ORCPT ); Wed, 16 Oct 2019 17:54:01 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D179021925; Wed, 16 Oct 2019 21:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262841; bh=/nAysgjTFmewi/5K89zTSe8m+NSh6ZbHkmJVyj9QHAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CUzwGpNafoBJxs0QGOeA6MBjtpWH9Lr3e198myUhQDwOfMLJOunFbU02u2TDH5NhC y0TymvrWOKTsZuEJm5oBcv+m6T0VZRKda9W+lAblRYAl8HPpoy3/8rRLnuYg6odBzH Wuko88zUcEKCArLxLHb1nIW3u7biugMPtxKiD4eM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.4 46/79] USB: chaoskey: fix use-after-free on release Date: Wed, 16 Oct 2019 14:50:21 -0700 Message-Id: <20191016214808.032672151@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 93ddb1f56ae102f14f9e46a9a9c8017faa970003 upstream. The driver was accessing its struct usb_interface in its release() callback without holding a reference. This would lead to a use-after-free whenever the device was disconnected while the character device was still open. Fixes: 66e3e591891d ("usb: Add driver for Altus Metrum ChaosKey device (v2)") Cc: stable # 4.1 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191009153848.8664-3-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/chaoskey.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/usb/misc/chaoskey.c +++ b/drivers/usb/misc/chaoskey.c @@ -96,6 +96,7 @@ static void chaoskey_free(struct chaoske usb_dbg(dev->interface, "free"); kfree(dev->name); kfree(dev->buf); + usb_put_intf(dev->interface); kfree(dev); } @@ -144,6 +145,8 @@ static int chaoskey_probe(struct usb_int if (dev == NULL) return -ENOMEM; + dev->interface = usb_get_intf(interface); + dev->buf = kmalloc(size, GFP_KERNEL); if (dev->buf == NULL) { @@ -169,8 +172,6 @@ static int chaoskey_probe(struct usb_int strcat(dev->name, udev->serial); } - dev->interface = interface; - dev->in_ep = in_ep; dev->size = size;