From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D21BFA3728 for ; Wed, 16 Oct 2019 21:53:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9D2121928 for ; Wed, 16 Oct 2019 21:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262828; bh=JTXGVBsdPTWFjOc1petNnhXeWZTP+Ad+9jQrGAdFgko=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bAOyKPM0u3kYJTgKUsub0UYVQCceS5nb7kz1pfbeo02sBTeEMXTCQb7Iz1cRzEAmV NOA63hhs5q/3k3dIUmudalYxCxBPQ1haFW075es7ArkNMBPDQyL0LKE+AKsuOxaB9/ GxQM6KZDZwWbFsJiKzOsgcZXUR5VS3CekJLYHQ48= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394894AbfJPVxr (ORCPT ); Wed, 16 Oct 2019 17:53:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:42562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437541AbfJPVxf (ORCPT ); Wed, 16 Oct 2019 17:53:35 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61C2021925; Wed, 16 Oct 2019 21:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262814; bh=JTXGVBsdPTWFjOc1petNnhXeWZTP+Ad+9jQrGAdFgko=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fXIxeAcZuJf0MOuOHzFxgG6DiefktyP9EXbnhH/g9pdyYEdYq1ZPiOgm8b9a77tfL 8ROtrSR3L2Rj+85n9pMdSEIP4agPCtLlP53sa9tyAmaWj3PP3ZTzEtO0+FK14QiRCl 75+nC4588vUI9y7nItIB4hjxBtZLkGUcttXsvhsM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yoshihiro Shimoda Subject: [PATCH 4.4 57/79] usb: renesas_usbhs: gadget: Do not discard queues in usb_ep_set_{halt,wedge}() Date: Wed, 16 Oct 2019 14:50:32 -0700 Message-Id: <20191016214819.867078789@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214729.758892904@linuxfoundation.org> References: <20191016214729.758892904@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yoshihiro Shimoda commit 1aae1394294cb71c6aa0bc904a94a7f2f1e75936 upstream. The commit 97664a207bc2 ("usb: renesas_usbhs: shrink spin lock area") had added a usbhsg_pipe_disable() calling into __usbhsg_ep_set_halt_wedge() accidentally. But, this driver should not call the usbhsg_pipe_disable() because the function discards all queues. So, this patch removes it. Fixes: 97664a207bc2 ("usb: renesas_usbhs: shrink spin lock area") Cc: # v3.1+ Signed-off-by: Yoshihiro Shimoda Link: https://lore.kernel.org/r/1569924633-322-2-git-send-email-yoshihiro.shimoda.uh@renesas.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/renesas_usbhs/mod_gadget.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c @@ -732,8 +732,6 @@ static int __usbhsg_ep_set_halt_wedge(st struct device *dev = usbhsg_gpriv_to_dev(gpriv); unsigned long flags; - usbhsg_pipe_disable(uep); - dev_dbg(dev, "set halt %d (pipe %d)\n", halt, usbhs_pipe_number(pipe));