From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D4FAFA3728 for ; Wed, 16 Oct 2019 22:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C3A520872 for ; Wed, 16 Oct 2019 22:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263236; bh=rex5Qlu9Yoib8q8n6GxuQ2Md0fpcln747nOg7+/Qw8k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iOkrIFTbrXxhIxT90gcjEX/aOtaUgOFkCjBhP5MULOQIkQwyCmT9Lj7/ZKaQm2Sy2 IR8soyJxYNIQQQWhOWoeZoomTOL+Yh9us52Xpox/yNNkUedC0Yn1pK4GXkDdhoB2rv /3shxc4QA55d2jidUpGm9BPweBhw1DybQDOH7ffQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438817AbfJPWAe (ORCPT ); Wed, 16 Oct 2019 18:00:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:54006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438481AbfJPV7V (ORCPT ); Wed, 16 Oct 2019 17:59:21 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 842EA218DE; Wed, 16 Oct 2019 21:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263160; bh=rex5Qlu9Yoib8q8n6GxuQ2Md0fpcln747nOg7+/Qw8k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F/XEYvH6pO5y9wwM/wjZEnzkdK4vJUI+6k/exuAcC6J2mgVAkn30GquDd3AfUD99S Enf6+nAiwlqyWM34aJQHW5l6bx11VNkQ/2ivjtkijz3sclQVqjcQP+DaPrqQBXfyQ6 3tEQWoZxxQ5wJ6ZwthzjFOVnvrUuu3mrkrfD4Jfc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Josef Bacik , David Sterba Subject: [PATCH 5.3 088/112] btrfs: fix uninitialized ret in ref-verify Date: Wed, 16 Oct 2019 14:51:20 -0700 Message-Id: <20191016214905.242142724@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214844.038848564@linuxfoundation.org> References: <20191016214844.038848564@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Josef Bacik commit c5f4987e86f6692fdb12533ea1fc7a7bb98e555a upstream. Coverity caught a case where we could return with a uninitialized value in ret in process_leaf. This is actually pretty likely because we could very easily run into a block group item key and have a garbage value in ret and think there was an errror. Fix this by initializing ret to 0. Reported-by: Colin Ian King Fixes: fd708b81d972 ("Btrfs: add a extent ref verify tool") CC: stable@vger.kernel.org # 4.19+ Signed-off-by: Josef Bacik Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/ref-verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/btrfs/ref-verify.c +++ b/fs/btrfs/ref-verify.c @@ -500,7 +500,7 @@ static int process_leaf(struct btrfs_roo struct btrfs_extent_data_ref *dref; struct btrfs_shared_data_ref *sref; u32 count; - int i = 0, tree_block_level = 0, ret; + int i = 0, tree_block_level = 0, ret = 0; struct btrfs_key key; int nritems = btrfs_header_nritems(leaf);