From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89920FA3728 for ; Wed, 16 Oct 2019 22:03:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5120420872 for ; Wed, 16 Oct 2019 22:03:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263387; bh=TZAzt8b0InQqkoVFvO0WAITq7FHov/uXFi2a0LWBaNE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=m4kEzYmuJ6kTIiB/Hsc86pZCokOdht4TZJ9vj1fwKnWGKfbFBxU1dB64W7f5nszK4 2F4wbmE6w1gMxomo6IiPksmyh86+ZHt/TvWP9D0BSdtxHSjWi2n1YIyY6jyjo7OvfS L/2XmPp/6rphad0/koC+MtQo8Zech/6AcVGowzn4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439047AbfJPWDF (ORCPT ); Wed, 16 Oct 2019 18:03:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:54432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438498AbfJPV7b (ORCPT ); Wed, 16 Oct 2019 17:59:31 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 183AA21D7C; Wed, 16 Oct 2019 21:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263171; bh=TZAzt8b0InQqkoVFvO0WAITq7FHov/uXFi2a0LWBaNE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f+gaMMpPvZML7tZziMlcLG/BEbj2gW8f10u3dIkV51RdfN3Xg0FKhxJPiQ/6FVwdh y/yuSFTLjKJ8tlX7+u++zQfZSAr/mvbkA9x1nFRhpEzoUsxYk9OaBCQrvsugLVH43S gp/9JHu+z4XoiJ6NcSUYarzHRZFFpti0FNkknu9Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kenneth Graunke , Chris Wilson , Rodrigo Vivi Subject: [PATCH 5.3 098/112] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Date: Wed, 16 Oct 2019 14:51:30 -0700 Message-Id: <20191016214906.224784666@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214844.038848564@linuxfoundation.org> References: <20191016214844.038848564@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kenneth Graunke commit 282b7fd5f5ab4eba499e1162c1e2802c6d0bb82e upstream. This allows userspace to use "legacy" mode for push constants, where they are committed at 3DPRIMITIVE or flush time, rather than being committed at 3DSTATE_BINDING_TABLE_POINTERS_XS time. Gen6-8 and Gen11 both use the "legacy" behavior - only Gen9 works in the "new" way. Conflating push constants with binding tables is painful for userspace, we would like to be able to avoid doing so. Signed-off-by: Kenneth Graunke Cc: stable@vger.kernel.org Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20190911014801.26821-1-kenneth@whitecape.org (cherry picked from commit 0606259e3b3a1220a0f04a92a1654a3f674f47ee) Signed-off-by: Rodrigo Vivi Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c @@ -1042,6 +1042,9 @@ static void gen9_whitelist_build(struct /* WaAllowUMDToModifyHDCChicken1:skl,bxt,kbl,glk,cfl */ whitelist_reg(w, GEN8_HDC_CHICKEN1); + + /* WaSendPushConstantsFromMMIO:skl,bxt */ + whitelist_reg(w, COMMON_SLICE_CHICKEN2); } static void skl_whitelist_build(struct intel_engine_cs *engine)