From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C1A7ECE599 for ; Wed, 16 Oct 2019 23:24:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFC532168B for ; Wed, 16 Oct 2019 23:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571268241; bh=igapbZGpLlKRzBdYxMTU1tCbvC2o5pyly0l6ltnqaAQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fIWsAg1ePgrd8Yas5R7KLz+Mrx8rj1mdOf802Yr9maK3Qb4O9EZL5jh7uaFJZVAcd PXnzPKypzUwdR1izuMxllFD7j9g3hgpgWrffNDxBkm17aNf+9xg/CjJvYRbVc0r4o7 0Kh8TKoK0OyMiJP4gymOvKpCa0SGPrO0HEu0/5+E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406074AbfJPXX7 (ORCPT ); Wed, 16 Oct 2019 19:23:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:54032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbfJPXX7 (ORCPT ); Wed, 16 Oct 2019 19:23:59 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1F8B20872; Wed, 16 Oct 2019 23:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571268238; bh=igapbZGpLlKRzBdYxMTU1tCbvC2o5pyly0l6ltnqaAQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1qbmwoid57B9hFBwPWg+OWygSZUrw22vI6dINmFlY7wSMOPDtrFUs06xMuHrOfJyL QZ7ZMEaGtm0XtCgt0z7sZQ+Tz85DuNq0ousESvViYgloWYilcgjXv2frZXWpVq8rgk 0qbasP5hiEQXf1i2A/Dp9WOzrwqDSIwtOfSZQ0kM= Date: Wed, 16 Oct 2019 16:23:58 -0700 From: Greg Kroah-Hartman To: Mark Brown Cc: Richard Leitner , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Oleksandr Suvorov , Marcel Ziswiler , Igor Opaniuk , Fabio Estevam Subject: Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control Message-ID: <20191016232358.GA994597@kroah.com> References: <20191016214844.038848564@linuxfoundation.org> <20191016214907.599726506@linuxfoundation.org> <20191016220044.GB11473@sirena.co.uk> <20191016221025.GA990599@kroah.com> <20191016223518.GC11473@sirena.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191016223518.GC11473@sirena.co.uk> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 16, 2019 at 11:35:18PM +0100, Mark Brown wrote: > On Wed, Oct 16, 2019 at 03:10:25PM -0700, Greg Kroah-Hartman wrote: > > On Wed, Oct 16, 2019 at 11:00:44PM +0100, Mark Brown wrote: > > > On Wed, Oct 16, 2019 at 02:51:44PM -0700, Greg Kroah-Hartman wrote: > > > > From: Oleksandr Suvorov > > > > > commit 694b14554d75f2a1ae111202e71860d58b434a21 upstream. > > > > > This control mute/unmute the ADC input of SGTL5000 > > > > using its CHIP_ANA_CTRL register. > > > > This seems like a new feature and not an obvious candidate for stable? > > > there was a long email from Richard that said: > > Upstream commit 631bc8f0134a ("ASoC: sgtl5000: Fix of unmute > > outputs on probe"), which is e9f621efaebd in v5.3 replaced > > snd_soc_component_write with snd_soc_component_update_bits and > > therefore no longer cleared the MUTE_ADC flag. This caused the > > ADC to stay muted and recording doesn't work any longer. This > > patch fixes this problem by adding a Switch control for > > MUTE_ADC. > > > That's why I took this. If this isn't true, I'll be glad to drop this. > > That's probably not an appropriate fix for stable - it's going to add a > new control which users will need to manually set (or hope their > userspace automatically figures out that it should set for them, more > advanced userspaces like PulseAudio should) which isn't a drop in fix. > You could either drop the backport that was done for zero cross or take > a new patch that clears the MUTE_ADC flag (rather than punting to > userspace to do so), or just be OK with what you've got at the minute > which might be fine given the lack of user reports. Ok, I'll gladly go drop it, thanks! greg k-h