* [PATCH net-next] pktgen: remove unnecessary assignment in pktgen_xmit()
@ 2019-10-17 10:34 Yunsheng Lin
2019-10-17 18:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yunsheng Lin @ 2019-10-17 10:34 UTC (permalink / raw)
To: davem
Cc: tglx, peterz, fw, bigeasy, pabeni, jonathan.lemon,
anshuman.khandual, netdev, linux-kernel, linuxarm
variable ret is not used after jumping to "unlock" label, so
the assignment is redundant.
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
---
net/core/pktgen.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 48b1e42..294bfcf 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3404,7 +3404,6 @@ static void pktgen_xmit(struct pktgen_dev *pkt_dev)
HARD_TX_LOCK(odev, txq, smp_processor_id());
if (unlikely(netif_xmit_frozen_or_drv_stopped(txq))) {
- ret = NETDEV_TX_BUSY;
pkt_dev->last_ok = 0;
goto unlock;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] pktgen: remove unnecessary assignment in pktgen_xmit()
2019-10-17 10:34 [PATCH net-next] pktgen: remove unnecessary assignment in pktgen_xmit() Yunsheng Lin
@ 2019-10-17 18:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-10-17 18:26 UTC (permalink / raw)
To: linyunsheng
Cc: tglx, peterz, fw, bigeasy, pabeni, jonathan.lemon,
anshuman.khandual, netdev, linux-kernel, linuxarm
From: Yunsheng Lin <linyunsheng@huawei.com>
Date: Thu, 17 Oct 2019 18:34:13 +0800
> variable ret is not used after jumping to "unlock" label, so
> the assignment is redundant.
>
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-17 18:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17 10:34 [PATCH net-next] pktgen: remove unnecessary assignment in pktgen_xmit() Yunsheng Lin
2019-10-17 18:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).