From: Jan Kara <jack@suse.cz>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk, Jan Kara <jack@suse.cz>,
Amir Goldstein <amir73il@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsnotify: move declaration of fsnotify_mark_connector_cachep to fsnotify.h
Date: Thu, 17 Oct 2019 10:32:26 +0200 [thread overview]
Message-ID: <20191017083226.GB20260@quack2.suse.cz> (raw)
In-Reply-To: <20191015132518.21819-1-ben.dooks@codethink.co.uk>
On Tue 15-10-19 14:25:18, Ben Dooks wrote:
> Move fsnotify_mark_connector_cachep to fsnotify.h to properly
> share it with the user in mark.c and avoid the following warning
> from sparse:
>
> fs/notify/mark.c:82:19: warning: symbol 'fsnotify_mark_connector_cachep' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
OK, fair enough. Applied. Thanks for the patch.
Honza
> ---
> Cc: Jan Kara <jack@suse.cz>
> Cc: Amir Goldstein <amir73il@gmail.com>
> Cc: linux-fsdevel@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> fs/notify/fsnotify.c | 2 --
> fs/notify/fsnotify.h | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/notify/fsnotify.c b/fs/notify/fsnotify.c
> index 2ecef6155fc0..3e77b728a22b 100644
> --- a/fs/notify/fsnotify.c
> +++ b/fs/notify/fsnotify.c
> @@ -381,8 +381,6 @@ int fsnotify(struct inode *to_tell, __u32 mask, const void *data, int data_is,
> }
> EXPORT_SYMBOL_GPL(fsnotify);
>
> -extern struct kmem_cache *fsnotify_mark_connector_cachep;
> -
> static __init int fsnotify_init(void)
> {
> int ret;
> diff --git a/fs/notify/fsnotify.h b/fs/notify/fsnotify.h
> index f3462828a0e2..ff2063ec6b0f 100644
> --- a/fs/notify/fsnotify.h
> +++ b/fs/notify/fsnotify.h
> @@ -65,4 +65,6 @@ extern void __fsnotify_update_child_dentry_flags(struct inode *inode);
> extern struct fsnotify_event_holder *fsnotify_alloc_event_holder(void);
> extern void fsnotify_destroy_event_holder(struct fsnotify_event_holder *holder);
>
> +extern struct kmem_cache *fsnotify_mark_connector_cachep;
> +
> #endif /* __FS_NOTIFY_FSNOTIFY_H_ */
> --
> 2.23.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2019-10-17 8:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 13:25 [PATCH] fsnotify: move declaration of fsnotify_mark_connector_cachep to fsnotify.h Ben Dooks
2019-10-17 8:32 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017083226.GB20260@quack2.suse.cz \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).