From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AAF2FA3733 for ; Thu, 17 Oct 2019 10:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B36B20869 for ; Thu, 17 Oct 2019 10:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408991AbfJQKtE (ORCPT ); Thu, 17 Oct 2019 06:49:04 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:40285 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404935AbfJQKtD (ORCPT ); Thu, 17 Oct 2019 06:49:03 -0400 X-Originating-IP: 86.207.98.53 Received: from localhost (aclermont-ferrand-651-1-259-53.w86-207.abo.wanadoo.fr [86.207.98.53]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 57C6360007; Thu, 17 Oct 2019 10:49:00 +0000 (UTC) Date: Thu, 17 Oct 2019 12:48:59 +0200 From: Alexandre Belloni To: "Vaittinen, Matti" Cc: "dmurphy@ti.com" , "linux-leds@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mturquette@baylibre.com" , "mazziesaccount@gmail.com" , "devicetree@vger.kernel.org" , "jacek.anaszewski@gmail.com" , "a.zummo@towertech.it" , "linus.walleij@linaro.org" , "lgirdwood@gmail.com" , "mark.rutland@arm.com" , "robh+dt@kernel.org" , "bgolaszewski@baylibre.com" , "linux-clk@vger.kernel.org" , "pavel@ucw.cz" , "sboyd@kernel.org" , "broonie@kernel.org" , "lee.jones@linaro.org" Subject: Re: [RFC PATCH 09/13] mfd: rtc: support RTC on ROHM BD71828 with BD70528 driver Message-ID: <20191017104859.GC3125@piout.net> References: <9ccc83f3dfd0fd0dc8178adf41b52115f960c45a.1571302099.git.matti.vaittinen@fi.rohmeurope.com> <20191017101225.GB3125@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/10/2019 10:36:44+0000, Vaittinen, Matti wrote: > Hello Alexandre, > > Thanks for quick check! I'll be off for the rest of the week but I will > re-work this patch at next week :) I agree with you regarding most of > the comments. > > > > + > > > + > > > +/* > > > + * RTC definitions shared between > > > + * > > > + * BD70528 > > > + * and BD71828 > > > + */ > > > + > > > +#define ROHM_BD1_MASK_RTC_SEC 0x7f > > > +#define ROHM_BD1_MASK_RTC_MINUTE 0x7f > > > +#define ROHM_BD1_MASK_RTC_HOUR_24H 0x80 > > > +#define ROHM_BD1_MASK_RTC_HOUR_PM 0x20 > > > +#define ROHM_BD1_MASK_RTC_HOUR 0x3f > > > +#define ROHM_BD1_MASK_RTC_DAY 0x3f > > > +#define ROHM_BD1_MASK_RTC_WEEK 0x07 > > > +#define ROHM_BD1_MASK_RTC_MONTH 0x1f > > > +#define ROHM_BD1_MASK_RTC_YEAR 0xff > > > +#define ROHM_BD1_MASK_ALM_EN 0x7 > > > + > > > > All that renaming is distracting and useless. Please resubmit without > > renaming defines, structs and functions to make it easier to review. > > I would prefer renaming because it makes it clearly visible which > defines/structs/functions are common for both PMICs and which are PMIC > specific. But I really understand the problem of spotting real changes. > Would it be Ok if I did renaming in separate patch which does not bring > in any other changes - and then the functional changes in separate > patch? > No, unless you can guarantee that all future PMICs from rohm matching the wildcard will use this driver. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com