From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B25EFA3733 for ; Thu, 17 Oct 2019 11:47:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21F922089C for ; Thu, 17 Oct 2019 11:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571312822; bh=BGGdP34jTjoBsKcz7gQvolmVC90iVG0fX2/bdXKMIa8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TMCHiCdsCfpsFyxv7PYeFZ+2i8jbm/RYuNSVQ5lE8ZE7Fr3oUJxTjlKHQTnIB4gLH 973fQbMrpLyCFHyHfkjF/S70YAtU9j+6oCc95hegeZbQsq7Y+/EMh+dU7oFvssNGuJ Ewcp0lupdWKvqi8ULOY2Sshg2RSD22stgAYvAZk4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502134AbfJQLrA (ORCPT ); Thu, 17 Oct 2019 07:47:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:59990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502113AbfJQLrA (ORCPT ); Thu, 17 Oct 2019 07:47:00 -0400 Received: from localhost (unknown [209.136.236.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 984A32082C; Thu, 17 Oct 2019 11:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571312818; bh=BGGdP34jTjoBsKcz7gQvolmVC90iVG0fX2/bdXKMIa8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RtPFd2ScxlErGSDcf344njs6dtqct63lCLYzog2Zj95NrZOUa9w2qL7vhmGOB0u5Y /8sqtm+N0I0SIrCT1VL9c9eSW2q/ZqSQBXBrjW6UqiK/t/QDzSesTbirgN3rFbiYs/ SwrXSo9gMHoYou9QNQboVYv1jCWXThs8W7dUBy7o= Date: Thu, 17 Oct 2019 04:46:58 -0700 From: Greg Kroah-Hartman To: Richard Leitner Cc: Mark Brown , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Oleksandr Suvorov , Marcel Ziswiler , Igor Opaniuk , Fabio Estevam Subject: Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control Message-ID: <20191017114658.GB1020613@kroah.com> References: <20191016214844.038848564@linuxfoundation.org> <20191016214907.599726506@linuxfoundation.org> <20191016220044.GB11473@sirena.co.uk> <20191016221025.GA990599@kroah.com> <20191016223518.GC11473@sirena.co.uk> <20191016232358.GA994597@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 17, 2019 at 11:20:32AM +0200, Richard Leitner wrote: > > On 17/10/2019 01:23, Greg Kroah-Hartman wrote: > > On Wed, Oct 16, 2019 at 11:35:18PM +0100, Mark Brown wrote: > > > On Wed, Oct 16, 2019 at 03:10:25PM -0700, Greg Kroah-Hartman wrote: > > > > On Wed, Oct 16, 2019 at 11:00:44PM +0100, Mark Brown wrote: > > > > > On Wed, Oct 16, 2019 at 02:51:44PM -0700, Greg Kroah-Hartman wrote: > > > > > > From: Oleksandr Suvorov > > > > > > > > > commit 694b14554d75f2a1ae111202e71860d58b434a21 upstream. > > > > > > > > > This control mute/unmute the ADC input of SGTL5000 > > > > > > using its CHIP_ANA_CTRL register. > > > > > > > > This seems like a new feature and not an obvious candidate for stable? > > > > > > > there was a long email from Richard that said: > > > > Upstream commit 631bc8f0134a ("ASoC: sgtl5000: Fix of unmute > > > > outputs on probe"), which is e9f621efaebd in v5.3 replaced > > > > snd_soc_component_write with snd_soc_component_update_bits and > > > > therefore no longer cleared the MUTE_ADC flag. This caused the > > > > ADC to stay muted and recording doesn't work any longer. This > > > > patch fixes this problem by adding a Switch control for > > > > MUTE_ADC. > > > > > > > That's why I took this. If this isn't true, I'll be glad to drop this. > > > > > > That's probably not an appropriate fix for stable - it's going to add a > > > new control which users will need to manually set (or hope their > > > userspace automatically figures out that it should set for them, more > > > advanced userspaces like PulseAudio should) which isn't a drop in fix. > > > You could either drop the backport that was done for zero cross or take > > > a new patch that clears the MUTE_ADC flag (rather than punting to > > > userspace to do so), or just be OK with what you've got at the minute > > > which might be fine given the lack of user reports. > > > > Ok, I'll gladly go drop it, thanks! > > Mark, thanks for the clarification! I haven't thought of breaking anything > with the backport as it worked fine for our application. > > Greg, just to be sure: > > Are you going to drop this patch and revert e9f621efaebd for v5.3? I dropped this patch. If the revert is needed, please send that and I will be glad to queue it up for the next round of releases. thanks, greg k-h