From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] riscv: add missing prototypes
Date: Fri, 18 Oct 2019 06:15:02 +0200 [thread overview]
Message-ID: <20191018041501.cuyyhcm23dsihcif@ltop.local> (raw)
In-Reply-To: <20191018004929.3445-6-paul.walmsley@sifive.com>
On Thu, Oct 17, 2019 at 05:49:26PM -0700, Paul Walmsley wrote:
> sparse identifies these missing prototypes when building arch/riscv:
>
> arch/riscv/kernel/cpu.c:149:29: warning: symbol 'cpuinfo_op' was not declared. Should it be static?
> arch/riscv/kernel/irq.c:27:29: warning: symbol 'do_IRQ' was not declared. Should it be static?
> arch/riscv/kernel/irq.c:57:13: warning: symbol 'init_IRQ' was not declared. Should it be static?
> arch/riscv/kernel/syscall_table.c:15:6: warning: symbol 'sys_call_table' was not declared. Should it be static?
> arch/riscv/kernel/time.c:15:13: warning: symbol 'time_init' was not declared. Should it be static?
> arch/riscv/kernel/smpboot.c:135:24: warning: symbol 'smp_callin' was not declared. Should it be static?
> arch/riscv/kernel/smp.c:72:5: warning: symbol 'setup_profiling_timer' was not declared. Should it be static?
> arch/riscv/mm/init.c:151:7: warning: symbol 'trampoline_pg_dir' was not declared. Should it be static?
> arch/riscv/mm/init.c:157:7: warning: symbol 'early_pg_dir' was not declared. Should it be static?
> arch/riscv/kernel/process.c:32:6: warning: symbol 'show_regs' was not declared. Should it be static?
> arch/riscv/kernel/ptrace.c:151:6: warning: symbol 'do_syscall_trace_enter' was not declared. Should it be static?
> arch/riscv/kernel/ptrace.c:165:6: warning: symbol 'do_syscall_trace_exit' was not declared. Should it be static?
>
> Fix by adding the missing prototypes to the appropriate header files.
For functions defined in C but used ony in assembly, you can also simply mark
them as '__visible' (aka __attribute__((exrernally_visible)) ).
Best regards,
-- Luc
next prev parent reply other threads:[~2019-10-18 5:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 0:49 [PATCH 0/8] riscv: resolve most warnings from sparse Paul Walmsley
2019-10-18 0:49 ` [PATCH 1/8] riscv: add prototypes for assembly language functions from entry.S Paul Walmsley
2019-10-18 0:49 ` [PATCH 2/8] riscv: add prototypes for assembly language functions from head.S Paul Walmsley
2019-10-18 1:15 ` Paul Walmsley
2019-10-18 0:49 ` [PATCH 3/8] riscv: init: merge split string literals in preprocessor directive Paul Walmsley
2019-10-18 4:02 ` Luc Van Oostenryck
2019-10-18 4:38 ` Paul Walmsley
2019-10-18 5:28 ` Luc Van Oostenryck
2019-10-18 5:47 ` Luc Van Oostenryck
2019-10-18 6:08 ` Paul Walmsley
2019-10-18 0:49 ` [PATCH 4/8] riscv: ensure RISC-V C model definitions are passed to static analyzers Paul Walmsley
2019-10-18 4:06 ` Luc Van Oostenryck
2019-10-18 4:39 ` Paul Walmsley
2019-10-18 5:25 ` Luc Van Oostenryck
2019-10-22 15:09 ` Palmer Dabbelt
2019-10-28 22:11 ` Luc Van Oostenryck
2019-10-18 0:49 ` [PATCH 5/8] riscv: add missing prototypes Paul Walmsley
2019-10-18 4:15 ` Luc Van Oostenryck [this message]
2019-10-18 6:06 ` Paul Walmsley
2019-10-18 0:49 ` [PATCH 6/8] riscv: mark some code and data as file-static Paul Walmsley
2019-10-18 0:49 ` [PATCH 7/8] riscv: add missing header file includes Paul Walmsley
2019-10-18 0:49 ` [PATCH 8/8] riscv: fp: add missing __user pointer annotations Paul Walmsley
2019-10-18 3:12 ` [PATCH 0/8] riscv: resolve most warnings from sparse Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018041501.cuyyhcm23dsihcif@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).