From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F0A3CA9EA3 for ; Fri, 18 Oct 2019 07:48:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1884321897 for ; Fri, 18 Oct 2019 07:48:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="qaH62j2v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504684AbfJRHsP (ORCPT ); Fri, 18 Oct 2019 03:48:15 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:40398 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727388AbfJRHsP (ORCPT ); Fri, 18 Oct 2019 03:48:15 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9I7iBwq174622; Fri, 18 Oct 2019 07:48:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=HDsYmxCIfhFTmMCndsVkdI9l3Qm8CX4mTlTcHOffK8I=; b=qaH62j2vDJwxe08T3kn0T/6YhfwIngpnpLd9azY/Q6ePgfGICFA7BVmMhZlCdVhwmm1y KK08Te821XYPhX+oL15mC8Qy5ybHnJMNcwu0ij4kcwNuqCaMEEZSmI4zAw3fUaO461nt IpgF2LSZRtkXMhINSb1wdVii5kSCak0fissoB9sTews17o8e9ZSAHgTOIoDOJSlAAkeT j/JFBoHt8F6qp7ww3lw3oUnJa+Y0LaXzPymyWU+QZTmp8qguE46eUqhqCaTRc5MjT04f B69Q1RWCeFUJWaHFW3tHrbCC2BeHq2V9h2zR1C5OEjxmIMeVh6B8fHNRKUz8rg5i6zlT Iw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2vq0q424dd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2019 07:48:05 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9I7loCp019672; Fri, 18 Oct 2019 07:48:04 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2vq0dxau8s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2019 07:48:04 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x9I7m00t000577; Fri, 18 Oct 2019 07:48:00 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 18 Oct 2019 07:48:00 +0000 Date: Fri, 18 Oct 2019 10:47:51 +0300 From: Dan Carpenter To: Kangjie Lu Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192e: initializing the wep buffer Message-ID: <20191018074751.GF24678@kadam> References: <20191018045800.10909-1-kjlu@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018045800.10909-1-kjlu@umn.edu> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9413 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910180076 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9413 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910180075 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 17, 2019 at 11:57:58PM -0500, Kangjie Lu wrote: > The "wep" buffer is not initialized. To avoid memory disclosures, > the fix initializes it, as peer functions like rtllib_ccmp_set_key > do. > > Signed-off-by: Kangjie Lu > --- > drivers/staging/rtl8192e/rtllib_crypt_wep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/rtl8192e/rtllib_crypt_wep.c b/drivers/staging/rtl8192e/rtllib_crypt_wep.c > index b1ea650036d2..0931777ed157 100644 > --- a/drivers/staging/rtl8192e/rtllib_crypt_wep.c > +++ b/drivers/staging/rtl8192e/rtllib_crypt_wep.c > @@ -232,6 +232,7 @@ static int prism2_wep_set_key(void *key, int len, u8 *seq, void *priv) > if (len < 0 || len > WEP_KEY_LEN) > return -1; > > + memset(wep, 0, sizeof(*wep)); > memcpy(wep->key, key, len); > wep->key_len = len; If we read beyond wep->key_len then it's probably a bug, right? It doesn't matter whether it's zeroed out or not. Fortunately we never do: memcpy(key, wep->key, wep->key_len); So this change isn't required. regards, dan carpenter