From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 606B0CA9EA0 for ; Fri, 18 Oct 2019 09:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 343FF21897 for ; Fri, 18 Oct 2019 09:29:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AC2Lkt+5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2409734AbfJRJ3h (ORCPT ); Fri, 18 Oct 2019 05:29:37 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:38147 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728723AbfJRJ3g (ORCPT ); Fri, 18 Oct 2019 05:29:36 -0400 Received: by mail-pg1-f196.google.com with SMTP id w3so3046517pgt.5 for ; Fri, 18 Oct 2019 02:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=g0wJcF0+MU8onT4dQlcS5SYf3gjezQhPtNmK0I7nY6I=; b=AC2Lkt+54mTJ8oA7oUAFoCNuCudKUP69OuYq8gUduwPZydK3rvBO//TtYfOpIs7xw9 rWyccryi7QP4SA2CgY8TDSk1BJx2ZDZKA1bx4OeOhUxBFo+ur3JbMEMrMHIw4o7PA28X vNtSql73UXPGvwZeNeYcyDBKU++Hduf0kh6uajhB0cgItaFqHMwHBP7fiEMxkcEpYPyM D4OgKxg7+leENuo/IGr+b85l2vhbRPT0HESQSADQbHmG53Rr1pkIjypouOU/ItHz+eAi UeP/TVHfsLAwAfgj/psAMseWVV5z4y0kxrQfA4LOipxDtAGpfAh0jckWOaaRYRhLM7px eVFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=g0wJcF0+MU8onT4dQlcS5SYf3gjezQhPtNmK0I7nY6I=; b=dvRpIKrLDkVVf9z0zTzsPRX9jx03CgSNxMrAQI3iPRWHlGJnbnQ2jMpR4Gau2kpy8c NFplNsbxX08e04VFzPPsIYx9+kft/aCwlmWHSj2P2Qe8IKE7qXgZhoi96IBUgKer+ccR DDuL8NhPHmFrNFq0qfecu1eOVXAhtPuP+BIkvKdomZpdvq2Gu8WGNy1T4rc8k0dSPLLv +7DMRcOgyChSkE7fh9ntGjahX1ydQ8+9+bUlt4/i0Fhs9uiN8Ineyp24GlDSiUTIaEil 4SW/2C0eW5EKwyTla8fB/beZAkhn+QksjSPWxENWBRZApCxjwJqmoJkQc5OuNyAyrQlG xu+Q== X-Gm-Message-State: APjAAAVZ4yZoliWcfbtcU4Oykkq4Qmp7eAXiWFrcdgTFdrzV6gHcRg5J Y2aDNdQN1fS3Xdez3F8z4JuJew== X-Google-Smtp-Source: APXvYqzdCKqUCleUtrRntSSQeapM3vme2IX5RXZxIKneWH/lOi7AQ4zNoe3fUN+iPFYS2lkzBOzWYQ== X-Received: by 2002:a63:5a59:: with SMTP id k25mr9044265pgm.171.1571390975933; Fri, 18 Oct 2019 02:29:35 -0700 (PDT) Received: from localhost ([122.172.151.112]) by smtp.gmail.com with ESMTPSA id r185sm5809366pfr.68.2019.10.18.02.29.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Oct 2019 02:29:35 -0700 (PDT) Date: Fri, 18 Oct 2019 14:59:33 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: "Rafael J. Wysocki" , Linux PM , Linux ACPI , LKML , Sudeep Holla Subject: Re: [RFT][PATCH 2/3] cpufreq: Use per-policy frequency QoS Message-ID: <20191018092933.2i7dpr35wkxemgby@vireshk-i7> References: <2811202.iOFZ6YHztY@kreacher> <20154332.AJkCBzCetj@kreacher> <1707f018-fc6b-0122-17e0-635340daa4ef@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-10-19, 00:29, Dmitry Osipenko wrote: > Viresh, the warning is actually triggered by this line: > > https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/opp/of.c#L664 > > So it looks like the cpufreq-dt driver removal drops > opp_table->list_kref more times than it should be. I may try to take a > closer look at it later on, please let me know if you have any suggestions. I was able to reproduce it and have sent a fix and cc'd you on it. Please give it a try. -- viresh