From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6930FCA9EA9 for ; Fri, 18 Oct 2019 18:08:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 453F9222C5 for ; Fri, 18 Oct 2019 18:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571422085; bh=ZZMyOK6Htbo2xVY3APNPQb5o1YLZhzh1tFYvN5fJBxc=; h=From:To:Cc:Subject:In-Reply-To:Date:List-ID:From; b=EFu/pfCWxxFX+hCKZa1Hbq6dAPQK84gm1CGIEXAODekLyX7+AUtzQc/h98QaBcD1k VKXvibNQaU0UALSj4LIKaRkiC4UPxcoTkX0mEyvKHDP1iUkh5em4x5QOmYF+fWjOBo pzibiNZhjtQ3r5jhCIx2BAwUf/x6f+RhPupzIheU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2634564AbfJRSH5 (ORCPT ); Fri, 18 Oct 2019 14:07:57 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:45362 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2505743AbfJRSHT (ORCPT ); Fri, 18 Oct 2019 14:07:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=+ZlHeGfrpTjU6PQ+KNMsRurvdye1OzjdR9gSL9BV4SI=; b=H3r14kUnkG0l U1iBqWReaeJqBm21j0q+n2hHSJ0LuU3dI1tGjzx190rpeKfL1bJdIqtNpF6062wW5H11AjyBc+Pmc m2lOlH5B62G6ZdF2IxA6bDcvmikWRbw6WshgxPR8LjFpIWYFbeUUlmcSPFq1T+LpPWVTMDbWunVGs VBtdo=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iLWeb-0004HK-Ig; Fri, 18 Oct 2019 18:07:09 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 17FD42743259; Fri, 18 Oct 2019 19:07:09 +0100 (BST) From: Mark Brown To: Gregory CLEMENT Cc: Alexandre Belloni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Ludovic Desroches , Mark Brown , Nicolas Ferre , Thomas Petazzoni Subject: Applied "spi: atmel: Remove and fix erroneous comments" to the spi tree In-Reply-To: <20191017141846.7523-2-gregory.clement@bootlin.com> X-Patchwork-Hint: ignore Message-Id: <20191018180709.17FD42743259@ypsilon.sirena.org.uk> Date: Fri, 18 Oct 2019 19:07:09 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch spi: atmel: Remove and fix erroneous comments has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 4d8672d17450b457c0dbbcfe9868438036b4647c Mon Sep 17 00:00:00 2001 From: Gregory CLEMENT Date: Thu, 17 Oct 2019 16:18:40 +0200 Subject: [PATCH] spi: atmel: Remove and fix erroneous comments Since CSAAT functionality support has been added. Some comments become wrong. Fix them to match the current driver behavior. Signed-off-by: Gregory CLEMENT Link: https://lore.kernel.org/r/20191017141846.7523-2-gregory.clement@bootlin.com Signed-off-by: Mark Brown --- drivers/spi/spi-atmel.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index e34ab587b980..7a17c3e2a8ee 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c @@ -312,11 +312,9 @@ static bool atmel_spi_is_v2(struct atmel_spi *as) * transmitted") Not so! Workaround uses nCSx pins as GPIOs; or newer * controllers have CSAAT and friends. * - * Since the CSAAT functionality is a bit weird on newer controllers as - * well, we use GPIO to control nCSx pins on all controllers, updating - * MR.PCS to avoid confusing the controller. Using GPIOs also lets us - * support active-high chipselects despite the controller's belief that - * only active-low devices/systems exists. + * Even controller newer than ar91rm9200, using GPIOs can make sens as + * it lets us support active-high chipselects despite the controller's + * belief that only active-low devices/systems exists. * * However, at91rm9200 has a second erratum whereby nCS0 doesn't work * right when driven with GPIO. ("Mode Fault does not allow more than one @@ -1193,8 +1191,6 @@ static int atmel_spi_setup(struct spi_device *spi) if (!as->use_cs_gpios) csr |= SPI_BIT(CSAAT); - /* DLYBS is mostly irrelevant since we manage chipselect using GPIOs. - */ csr |= SPI_BF(DLYBS, 0); word_delay_csr = atmel_word_delay_csr(spi, as); -- 2.20.1