From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A5ECA9EAB for ; Fri, 18 Oct 2019 18:48:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36C8020640 for ; Fri, 18 Oct 2019 18:48:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nq7ifkSW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2634596AbfJRSsU (ORCPT ); Fri, 18 Oct 2019 14:48:20 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:33059 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2634584AbfJRSsT (ORCPT ); Fri, 18 Oct 2019 14:48:19 -0400 Received: by mail-pf1-f193.google.com with SMTP id q10so4433010pfl.0; Fri, 18 Oct 2019 11:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GhekFAP9STOj7Nck5xlc736VlW5iBvMLqnVMOxCxKvk=; b=nq7ifkSWIToa5I6g+4rLSg8PHDlLTw6sVriPzMqwLyL1U5F8+028XAzlRa/udM37u2 IhA0UyYp6F+7ywfOdfaNWxQCMTMOWuL8HtxDQEhuCxw2TfjeU/1gdW7t93bK+VDfAcTg pfo6iiwkuaTPalYjOaazTni3qU5XLRdsfiyDPqItneeA0bQXnbaHtFuw8iRGNjF39B4W lt5QbWDbHM+8WrHSoEaeDZEsnNjlqC5r2UARp1vfD9y8vj6/yXwpuuBlqOTTfDzBXDs9 +FfX0SLtOMSWhq1Ah85J0QQWGmRg77zVUbZGDPG1IKY0ugY8WtqD7mvAONygnf9oMrZb NTTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GhekFAP9STOj7Nck5xlc736VlW5iBvMLqnVMOxCxKvk=; b=WT39LAVeVDYkaZzBN+leNcOM+/EUZNhZgolBo1DTzveRAfusSAv2OT8cPilHv63O2Z fbt47K9vKtahZ3l4aOEKdfK744qoK5xVu33E6VQH2R0TTjKiWyfn38hISlHwl3ddj8j3 p2h0vnN7W3k80WIYHJapHal7hsGOKSO1Y532yqbj/dufCmCdkHjdDxCfArV3wEwKFOb0 RIZo8iwFObFDKHdjE53KZddYM9WhpVBI8kOqR8BgYIF8vFehRV8z4b4aBLjOZEAoFREL zIPDWxJ9MPu307WgzEh8fYvBQTKRgIzhkOlQ9kLdf1STA/6tAwpdGl87QSKlCXAqJqXA TOPQ== X-Gm-Message-State: APjAAAWu32/xOh4fFSqMwpHLpJJF2UeOuneuBtIcBGc7Ja6xO9eKuwo+ 1lrl4qIbp61LlwFE/ftYc30= X-Google-Smtp-Source: APXvYqwsgKLXB40xjU+zPd0jglpCieWEDSonZkG9+b++J833wiGysvtehr/Wkf0Gua652wYqwRTXxQ== X-Received: by 2002:a63:1511:: with SMTP id v17mr11529604pgl.34.1571424498309; Fri, 18 Oct 2019 11:48:18 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id u5sm8212572pfl.25.2019.10.18.11.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 11:48:17 -0700 (PDT) Date: Fri, 18 Oct 2019 11:48:15 -0700 From: Dmitry Torokhov To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , linux-input@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 29/46] Input: touchscreen: use wrapper for pxa2xx ac97 registers Message-ID: <20191018184815.GP35946@dtor-ws> References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-29-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018154201.1276638-29-arnd@arndb.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 18, 2019 at 05:41:44PM +0200, Arnd Bergmann wrote: > To avoid a dependency on the pxa platform header files with > hardcoded registers, change the driver to call a wrapper > in the pxa2xx-ac97-lib that encapsulates all the other > ac97 stuff. Not supper happy about adding module dependencies. Can we include mach/regs-ac97.h from include/sound/pxa2xx-lib.h and use static inlines? Someone needs to include mach/regs-ac97.h in the end... Or there is something later in the series that needs it? Thanks. -- Dmitry