From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4EFBCA9EA0 for ; Fri, 18 Oct 2019 22:07:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 792F422459 for ; Fri, 18 Oct 2019 22:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571436469; bh=jSBSivH/u/IsPoQL2DioWtRFhPnTgBDj9HejaCxueSs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RsSA8+pyBNFml5WxvckXqaBRY6R9yH3QJmok7wWDXsQtXMB6rLyjzc5EC9X5/r/Mx SzpirWQVTGGicSuQT77caprcGnqqi7mGu+gzXcRkx1Ry4SY6q2rDkFe7mOLXsQGZxy V7FTtoetmO2gTkGyvIbdfjmon1IG1UmbSw8HgSPo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733264AbfJRWHs (ORCPT ); Fri, 18 Oct 2019 18:07:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:40150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733196AbfJRWHp (ORCPT ); Fri, 18 Oct 2019 18:07:45 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98848222C2; Fri, 18 Oct 2019 22:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571436465; bh=jSBSivH/u/IsPoQL2DioWtRFhPnTgBDj9HejaCxueSs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pTQ993C5XxCZoli8vnIOOZ71Vf6N9+aJkjJYafgc9ymT8lSjPfKSCOIoR3ms4h8Hm 6ksEXj0VVJlzERnQb8zbifdT0lqoIcwIkn/rllSeOhEfsrBjjGkKrjGMcRWiIw86JJ ygjFC62aBbY0565SMiYM/MscvQHxp2JxeVw/GCEs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Johan Hovold , Greg Kroah-Hartman , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 095/100] USB: usb-skeleton: fix use-after-free after driver unbind Date: Fri, 18 Oct 2019 18:05:20 -0400 Message-Id: <20191018220525.9042-95-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191018220525.9042-1-sashal@kernel.org> References: <20191018220525.9042-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold [ Upstream commit 6353001852776e7eeaab4da78922d4c6f2b076af ] The driver failed to stop its read URB on disconnect, something which could lead to a use-after-free in the completion handler after driver unbind in case the character device has been closed. Fixes: e7389cc9a7ff ("USB: skel_read really sucks royally") Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191009170944.30057-3-johan@kernel.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/usb-skeleton.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c index f101347e3ea35..a14dc5003a294 100644 --- a/drivers/usb/usb-skeleton.c +++ b/drivers/usb/usb-skeleton.c @@ -574,6 +574,7 @@ static void skel_disconnect(struct usb_interface *interface) dev->interface = NULL; mutex_unlock(&dev->io_mutex); + usb_kill_urb(dev->bulk_in_urb); usb_kill_anchored_urbs(&dev->submitted); /* decrement our usage count */ -- 2.20.1