From: Eyal Birger <eyal.birger@gmail.com>
To: Zhiyuan Hou <zhiyuan2048@linux.alibaba.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S . Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
shmulik.ladkani@gmail.com
Subject: Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection
Date: Sat, 19 Oct 2019 00:25:02 +0300 [thread overview]
Message-ID: <20191019002502.0519ea9b@jimi> (raw)
In-Reply-To: <e16cfafe-059c-3106-835e-d32b7bb5ba61@linux.alibaba.com>
Hi,
On Fri, 18 Oct 2019 00:33:53 +0800
Zhiyuan Hou <zhiyuan2048@linux.alibaba.com> wrote:
> On 2019/10/16 8:13 下午, Eyal Birger wrote:
> > Hi,
> >
> > On Wed, 16 Oct 2019 01:22:01 +0800
> > Zhiyuan Hou <zhiyuan2048@linux.alibaba.com> wrote:
> >
> >> On 2019/10/15 1:57 上午, Cong Wang wrote:
> >>> On Sat, Oct 12, 2019 at 12:16 AM Zhiyuan Hou
> >>> <zhiyuan2048@linux.alibaba.com> wrote:
> >>>> diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c
> >>>> index 9ce073a05414..6108a64c0cd5 100644
> >>>> --- a/net/sched/act_mirred.c
> >>>> +++ b/net/sched/act_mirred.c
> >>>> @@ -18,6 +18,7 @@
> >>>> #include <linux/gfp.h>
> >>>> #include <linux/if_arp.h>
> >>>> #include <net/net_namespace.h>
> >>>> +#include <net/dst.h>
> >>>> #include <net/netlink.h>
> >>>> #include <net/pkt_sched.h>
> >>>> #include <net/pkt_cls.h>
> >>>> @@ -298,8 +299,10 @@ static int tcf_mirred_act(struct sk_buff
> >>>> *skb, const struct tc_action *a,
> >>>>
> >>>> if (!want_ingress)
> >>>> err = dev_queue_xmit(skb2);
> >>>> - else
> >>>> + else {
> >>>> + skb_dst_drop(skb2);
> >>>> err = netif_receive_skb(skb2);
> >>>> + }
> >>> Good catch!
> > Indeed! Thanks for fixing this!
> >
> >>> I don't want to be picky, but it seems this is only needed
> >>> when redirecting from egress to ingress, right? That is,
> >>> ingress to ingress, or ingress to egress is okay? If not,
> >>> please fix all the cases while you are on it?
> >> Sure. But I think this patch is also needed when redirecting from
> >> ingress to ingress. Because we cannot assure that a skb has null
> >> dst in ingress redirection path. For example, if redirecting a skb
> >> from loopback's ingress to other device's ingress, the skb will
> >> take a dst.
> >>
> >> As commit logs point out, skb with valid dst cannot be made routing
> >> decision in following process. original dst may cause skb loss or
> >> other unexpected behavior.
> > On the other hand, removing the dst on ingress-to-ingress
> > redirection may remove LWT information on incoming packets, which
> > may be undesired.
> Sorry, I do not understand why lwt information is needed on
> ingress-to-ingress redirection. lwt is used on output path, isn't it?
> Can you please give more information?
On rx path tunnelled packets parameters received on a collect_md tunnel device
are kept in a metadata dst. See ip_tunnel_rcv() 'tun_dst' parameter.
The rx metadata dst can be matched by a number of mechanisms like routing
rules, eBPF, OVS, and netfilter.
Eyal.
next prev parent reply other threads:[~2019-10-18 21:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 7:16 [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection Zhiyuan Hou
2019-10-12 10:59 ` Eric Dumazet
2019-10-14 7:07 ` Zhiyuan Hou
2019-10-14 12:46 ` Eric Dumazet
2019-10-17 16:08 ` Zhiyuan Hou
2019-10-12 19:34 ` Sergei Shtylyov
2019-10-14 7:08 ` Zhiyuan Hou
2019-10-14 17:57 ` Cong Wang
2019-10-15 17:22 ` Zhiyuan Hou
2019-10-16 12:13 ` Eyal Birger
2019-10-17 16:33 ` Zhiyuan Hou
2019-10-18 21:25 ` Eyal Birger [this message]
2019-10-21 13:06 ` Zhiyuan Hou
2019-10-21 20:50 ` Cong Wang
2019-10-22 10:37 ` Eyal Birger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191019002502.0519ea9b@jimi \
--to=eyal.birger@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shmulik.ladkani@gmail.com \
--cc=xiyou.wangcong@gmail.com \
--cc=zhiyuan2048@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).