From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B6ADCA9EB5 for ; Mon, 21 Oct 2019 05:55:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0EC52089C for ; Mon, 21 Oct 2019 05:55:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QEsYal5I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726566AbfJUFzM (ORCPT ); Mon, 21 Oct 2019 01:55:12 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:46819 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727261AbfJUFyW (ORCPT ); Mon, 21 Oct 2019 01:54:22 -0400 Received: by mail-pf1-f195.google.com with SMTP id q5so7681203pfg.13 for ; Sun, 20 Oct 2019 22:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8emxxlyv0hfOTgOOWBUsQUpOlmvH2jBaXtEtprCbnfQ=; b=QEsYal5IjLMhnSvwqYnWTC1cGImeuZg5zYsuCBeORCFFYfeGHipQQiEWg6jKzClb+c MZTu3m9mT3MSVcuS3NJY3HI/kgL7aEOc1iuYar+t5pWRxe/9Pu75j56hWm6IhNHaFqAV E+g8aQdvYFktGh2uoqA/QpTmX9bA8cd0mR3Zg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8emxxlyv0hfOTgOOWBUsQUpOlmvH2jBaXtEtprCbnfQ=; b=LgKHPQAJHV65xAdcbBx569UBqh/Tjuz0+jEphxVE364lB6yR0cBd3TbrhOxm68DKEK NqPUznkKXYZxZZGqxkzJzf0/4pwmv0Jbq5ZSfOGNkah/BJSs7SToxO1d3oQo9sBdRjF/ p3bRHZPW1z3IvTN8zSWM/erNTvVkcW8vtDteTPcWNPi8f1cLeSQxDYQXrelryXPgz9Ke 4l7xav2VdddRNneGFJW8Cph3ag26NZrY7enz+GWpMswID3YFAJKnsUQCvXbbdwVskykY bd7tET3lreMJsMpKpZv3dRzCCqW3WILjZxqZfxDoYKXjv99IthtB9hgzlUBU+VpWB1Ya nhWA== X-Gm-Message-State: APjAAAUVygguCWnspUesK5aBj4YAfjAC5Ix15EL8C8ZYD2pfCQX44DhQ FNra30YFNjFtSbY3FQkWAMENRg== X-Google-Smtp-Source: APXvYqx2iXs9sZJnmULUcwsogTtABgRk9/VAH8NymvwT5xOT+nEept4zrlkYzUNbZBVIoiwwZKFkrA== X-Received: by 2002:a65:5541:: with SMTP id t1mr23450120pgr.39.1571637261616; Sun, 20 Oct 2019 22:54:21 -0700 (PDT) Received: from localhost ([2620:15c:202:1:3c8f:512b:3522:dfaf]) by smtp.gmail.com with ESMTPSA id l62sm15062699pfl.167.2019.10.20.22.54.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Oct 2019 22:54:21 -0700 (PDT) From: Gwendal Grignou To: briannorris@chromium.org, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, lee.jones@linaro.org, bleung@chromium.org, enric.balletbo@collabora.com, dianders@chromium.org, groeck@chromium.org, fabien.lahoudere@collabora.com Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Enrico Granata , Gwendal Grignou Subject: [PATCH v2 06/18] platform: chrome: cros_ec: Do not attempt to register a non-positive IRQ number Date: Sun, 20 Oct 2019 22:53:51 -0700 Message-Id: <20191021055403.67849-7-gwendal@chromium.org> X-Mailer: git-send-email 2.23.0.866.gb869b98d4c-goog In-Reply-To: <20191021055403.67849-1-gwendal@chromium.org> References: <20191021055403.67849-1-gwendal@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Enrico Granata Add a layer of sanity checking to cros_ec_register against attempting to register IRQ values that are not strictly greater than 0. Signed-off-by: Enrico Granata Signed-off-by: Gwendal Grignou --- Changes in v2: Remove dual Enrico's signature. drivers/platform/chrome/cros_ec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c index 739f3cffe26e3..9b19f50572313 100644 --- a/drivers/platform/chrome/cros_ec.c +++ b/drivers/platform/chrome/cros_ec.c @@ -149,7 +149,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev) return err; } - if (ec_dev->irq) { + if (ec_dev->irq > 0) { err = devm_request_threaded_irq( dev, ec_dev->irq, ec_irq_handler, ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT, -- 2.23.0.866.gb869b98d4c-goog