From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D23C3CA9EAF for ; Mon, 21 Oct 2019 12:31:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A80B4205C9 for ; Mon, 21 Oct 2019 12:31:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="m2tpD4CL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728756AbfJUMbx (ORCPT ); Mon, 21 Oct 2019 08:31:53 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55390 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727685AbfJUMbx (ORCPT ); Mon, 21 Oct 2019 08:31:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/0WHOLj1WHltl84XL/M5JBKcWuG1ZK/0/anzpUvZ6Mk=; b=m2tpD4CLPnV6PKZs9O6qht/+Ir oHtcXukEIoVv+VYy4vPRLbL+72uMeoqJCslBmWI1Nm0nmjaVi6yrxphdQFmW0YKLlDHl2ZsXtL0NA 3dt+/VaUQYWtCB7gX1TGuDBL6YDE5jF7MVlR60D4kiidx1Nb7arLNVdmr7QxGbb7xyjE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iMWqj-0004J2-Gk; Mon, 21 Oct 2019 14:31:49 +0200 Date: Mon, 21 Oct 2019 14:31:49 +0200 From: Andrew Lunn To: Vivien Didelot Cc: "David S. Miller" , linux-kernel@vger.kernel.org, Florian Fainelli , netdev@vger.kernel.org Subject: Re: [PATCH net-next 01/16] net: dsa: use dsa_to_port helper everywhere Message-ID: <20191021123149.GB16084@lunn.ch> References: <20191020031941.3805884-1-vivien.didelot@gmail.com> <20191020031941.3805884-2-vivien.didelot@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191020031941.3805884-2-vivien.didelot@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 19, 2019 at 11:19:26PM -0400, Vivien Didelot wrote: > Do not let the drivers access the ds->ports static array directly > while there is a dsa_to_port helper for this purpose. > > At the same time, un-const this helper since the SJA1105 driver > assigns the priv member of the returned dsa_port structure. Hi Vivien Is priv the only member we expect drivers to change? Is the rest private to the core/RO? Rather then remove the const, i wonder if it would be better to add a helper to set priv? Otherwise: Reviewed-by: Andrew Lunn Andrew