From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAED2CA9EB0 for ; Mon, 21 Oct 2019 17:11:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC52E2084B for ; Mon, 21 Oct 2019 17:11:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728800AbfJURLL (ORCPT ); Mon, 21 Oct 2019 13:11:11 -0400 Received: from muru.com ([72.249.23.125]:38502 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727328AbfJURLL (ORCPT ); Mon, 21 Oct 2019 13:11:11 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 059FB80CC; Mon, 21 Oct 2019 17:11:41 +0000 (UTC) Date: Mon, 21 Oct 2019 10:11:04 -0700 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: Mark Rutland , Ulf Hansson , devicetree@vger.kernel.org, Yangtao Li , linux-wireless@vger.kernel.org, Kefeng Wang , Bjorn Helgaas , letux-kernel@openphoenux.org, "Rafael J. Wysocki" , Russell King , Mike Rapoport , Kalle Valo , Petr Mladek , =?utf-8?Q?Beno=C3=AEt?= Cousson , kernel@pyra-handheld.com, Alexios Zavras , Rob Herring , John Stultz , David Sterba , Thomas Gleixner , linux-omap@vger.kernel.org, Allison Randal , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Sakari Ailus , netdev@vger.kernel.org Subject: Re: [PATCH v2 07/11] omap: remove old hsmmc.[ch] and in Makefile Message-ID: <20191021171104.GY5610@atomide.com> References: <9bd4c0bb0df26523d7f5265cdb06d86d63dafba8.1571510481.git.hns@goldelico.com> <20191021143008.GS5610@atomide.com> <3FDBE28F-B2C5-4EDE-905C-687F601462B6@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3FDBE28F-B2C5-4EDE-905C-687F601462B6@goldelico.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * H. Nikolaus Schaller [191021 17:08]: > > > Am 21.10.2019 um 16:30 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [191019 18:43]: > >> --- a/arch/arm/mach-omap2/Makefile > >> +++ b/arch/arm/mach-omap2/Makefile > >> @@ -216,7 +216,6 @@ obj-$(CONFIG_MACH_NOKIA_N8X0) += board-n8x0.o > >> > >> # Platform specific device init code > >> > >> -omap-hsmmc-$(CONFIG_MMC_OMAP_HS) := hsmmc.o > >> obj-y += $(omap-hsmmc-m) $(omap-hsmmc-y) > > > > The related obj-y line can go now too, right? > > Yes, I think so. It is a construction that I have never seen before :) > Therefore I did not recognize that it is related. > > > And looks like common.h also has struct omap2_hsmmc_info > > so maybe check by grepping for hsmmc_info to see it's gone. > > Yes, it is just a forward-declaration of the struct name with > no user anywhere. > > Scheduled for v3. > > BTW: should this series go through your tree since it is an > omap machine? Or MMC tree as that's where the code change really are. Regards, Tony