From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5DAACA9EB0 for ; Mon, 21 Oct 2019 16:39:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C22120659 for ; Mon, 21 Oct 2019 16:39:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571675992; bh=24sY/4YbTVozVy+uRaCPFe5IEYSBPEnCn/+jA2lhlA4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=tSUzOX1lziBBvSJVzC4U8cIoRKpdLA7c5OZZkyI/ziEq0ddAsXDK51QDSPcs4g5fw LVPM73yNgx0QBGMnGsE/hjjmNNwNnod4xFhN1rtSeHzymtX+Xl5jlbKPl/nOypU7BW pCl6oWlVO8xWCpvLAdSyaPXkST3KADUGJnvuAvZE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728780AbfJUQjv (ORCPT ); Mon, 21 Oct 2019 12:39:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:43896 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726819AbfJUQjv (ORCPT ); Mon, 21 Oct 2019 12:39:51 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84CC82053B; Mon, 21 Oct 2019 16:39:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571675989; bh=24sY/4YbTVozVy+uRaCPFe5IEYSBPEnCn/+jA2lhlA4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hHbQ0nZEF1b/in+qJOIPKq7ydJI4VD4cv2KyFv/e4KDfm1IZtGzooJlYvxRYyjgrt VB3RKD+2n3gF+k4Q4E2r+NCMmUAwKefPQ/iPXspHZD/DcjYPmWj1ezLXWL1VqPMFQ9 sXhQD2IJVJH5kJceNj+avfeZIj0ewXr1HxjtRago= Date: Mon, 21 Oct 2019 17:39:44 +0100 From: Jonathan Cameron To: Gwendal Grignou Cc: briannorris@chromium.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, lee.jones@linaro.org, bleung@chromium.org, enric.balletbo@collabora.com, dianders@chromium.org, groeck@chromium.org, fabien.lahoudere@collabora.com, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH v2 15/18] iio: cros_ec: Remove pm function Message-ID: <20191021173944.7bd0a865@archlinux> In-Reply-To: <20191021055403.67849-16-gwendal@chromium.org> References: <20191021055403.67849-1-gwendal@chromium.org> <20191021055403.67849-16-gwendal@chromium.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Oct 2019 22:54:00 -0700 Gwendal Grignou wrote: > Since cros_ec_sensorhub is shutting down the FIFO when the device > suspends, no need to slow down the EC sampling period rate. > It was necesseary to do that before command CMD_FIFO_INT_ENABLE was > introduced, but now all supported chromebooks have it. > > Signed-off-by: Gwendal Grignou Fair enough. Acked-by: Jonathan Cameron > --- > New in v2. > > .../cros_ec_sensors/cros_ec_lid_angle.c | 1 - > .../common/cros_ec_sensors/cros_ec_sensors.c | 1 - > .../cros_ec_sensors/cros_ec_sensors_core.c | 47 ------------------- > drivers/iio/light/cros_ec_light_prox.c | 1 - > .../linux/iio/common/cros_ec_sensors_core.h | 5 -- > 5 files changed, 55 deletions(-) > > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_lid_angle.c b/drivers/iio/common/cros_ec_sensors/cros_ec_lid_angle.c > index e30a59fcf0f95..af801e203623e 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_lid_angle.c > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_lid_angle.c > @@ -127,7 +127,6 @@ MODULE_DEVICE_TABLE(platform, cros_ec_lid_angle_ids); > static struct platform_driver cros_ec_lid_angle_platform_driver = { > .driver = { > .name = DRV_NAME, > - .pm = &cros_ec_sensors_pm_ops, > }, > .probe = cros_ec_lid_angle_probe, > .id_table = cros_ec_lid_angle_ids, > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > index 9e7903ff99f80..2eb4bb254fbde 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > @@ -314,7 +314,6 @@ MODULE_DEVICE_TABLE(platform, cros_ec_sensors_ids); > static struct platform_driver cros_ec_sensors_platform_driver = { > .driver = { > .name = "cros-ec-sensors", > - .pm = &cros_ec_sensors_pm_ops, > }, > .probe = cros_ec_sensors_probe, > .id_table = cros_ec_sensors_ids, > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > index 3d2e17093c75a..e89c355bb4b35 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > @@ -716,52 +716,5 @@ int cros_ec_sensors_core_write(struct cros_ec_sensors_core_state *st, > } > EXPORT_SYMBOL_GPL(cros_ec_sensors_core_write); > > -static int __maybe_unused cros_ec_sensors_prepare(struct device *dev) > -{ > - struct iio_dev *indio_dev = dev_get_drvdata(dev); > - struct cros_ec_sensors_core_state *st = iio_priv(indio_dev); > - > - if (st->curr_sampl_freq == 0) > - return 0; > - > - /* > - * If the sensors are sampled at high frequency, we will not be able to > - * sleep. Set sampling to a long period if necessary. > - */ > - if (st->curr_sampl_freq < CROS_EC_MIN_SUSPEND_SAMPLING_FREQUENCY) { > - mutex_lock(&st->cmd_lock); > - st->param.cmd = MOTIONSENSE_CMD_EC_RATE; > - st->param.ec_rate.data = CROS_EC_MIN_SUSPEND_SAMPLING_FREQUENCY; > - cros_ec_motion_send_host_cmd(st, 0); > - mutex_unlock(&st->cmd_lock); > - } > - return 0; > -} > - > -static void __maybe_unused cros_ec_sensors_complete(struct device *dev) > -{ > - struct iio_dev *indio_dev = dev_get_drvdata(dev); > - struct cros_ec_sensors_core_state *st = iio_priv(indio_dev); > - > - if (st->curr_sampl_freq == 0) > - return; > - > - if (st->curr_sampl_freq < CROS_EC_MIN_SUSPEND_SAMPLING_FREQUENCY) { > - mutex_lock(&st->cmd_lock); > - st->param.cmd = MOTIONSENSE_CMD_EC_RATE; > - st->param.ec_rate.data = st->curr_sampl_freq; > - cros_ec_motion_send_host_cmd(st, 0); > - mutex_unlock(&st->cmd_lock); > - } > -} > - > -const struct dev_pm_ops cros_ec_sensors_pm_ops = { > -#ifdef CONFIG_PM_SLEEP > - .prepare = cros_ec_sensors_prepare, > - .complete = cros_ec_sensors_complete > -#endif > -}; > -EXPORT_SYMBOL_GPL(cros_ec_sensors_pm_ops); > - > MODULE_DESCRIPTION("ChromeOS EC sensor hub core functions"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/iio/light/cros_ec_light_prox.c b/drivers/iio/light/cros_ec_light_prox.c > index da40c38370965..6bac02cdd898a 100644 > --- a/drivers/iio/light/cros_ec_light_prox.c > +++ b/drivers/iio/light/cros_ec_light_prox.c > @@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(platform, cros_ec_light_prox_ids); > static struct platform_driver cros_ec_light_prox_platform_driver = { > .driver = { > .name = "cros-ec-light-prox", > - .pm = &cros_ec_sensors_pm_ops, > }, > .probe = cros_ec_light_prox_probe, > .id_table = cros_ec_light_prox_ids, > diff --git a/include/linux/iio/common/cros_ec_sensors_core.h b/include/linux/iio/common/cros_ec_sensors_core.h > index b4eb3790cde11..db3da7ffcc376 100644 > --- a/include/linux/iio/common/cros_ec_sensors_core.h > +++ b/include/linux/iio/common/cros_ec_sensors_core.h > @@ -30,9 +30,6 @@ enum { > */ > #define CROS_EC_SAMPLE_SIZE (sizeof(s64) * 2) > > -/* Minimum sampling period to use when device is suspending */ > -#define CROS_EC_MIN_SUSPEND_SAMPLING_FREQUENCY 1000 /* 1 second */ > - > typedef irqreturn_t (*cros_ec_sensors_capture_t)(int irq, void *p); > > > @@ -119,8 +116,6 @@ int cros_ec_sensors_core_write(struct cros_ec_sensors_core_state *st, > struct iio_chan_spec const *chan, > int val, int val2, long mask); > > -extern const struct dev_pm_ops cros_ec_sensors_pm_ops; > - > /* List of extended channel specification for all sensors */ > extern const struct iio_chan_spec_ext_info cros_ec_sensors_ext_info[]; >