From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C61CA9EA0 for ; Tue, 22 Oct 2019 08:00:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CAAE21872 for ; Tue, 22 Oct 2019 08:00:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388059AbfJVIAE (ORCPT ); Tue, 22 Oct 2019 04:00:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:48700 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726978AbfJVIAD (ORCPT ); Tue, 22 Oct 2019 04:00:03 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 51494B872; Tue, 22 Oct 2019 08:00:02 +0000 (UTC) Date: Tue, 22 Oct 2019 10:00:00 +0200 From: Oscar Salvador To: Naoya Horiguchi Cc: "mhocko@kernel.org" , "mike.kravetz@oracle.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH v2 10/16] mm,hwpoison: Rework soft offline for free pages Message-ID: <20191022075959.GD19060@linux> References: <20191017142123.24245-1-osalvador@suse.de> <20191017142123.24245-11-osalvador@suse.de> <20191021074533.GA10507@hori.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191021074533.GA10507@hori.linux.bs1.fc.nec.co.jp> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 21, 2019 at 07:45:33AM +0000, Naoya Horiguchi wrote: > > +extern bool take_page_off_buddy(struct page *page); > > + > > +static void page_handle_poison(struct page *page) > > hwpoison is a separate idea from page poisoning, so maybe I think > it's better to be named like page_handle_hwpoison(). Yeah, that sounds better. > BTW, if we consider to make unpoison mechanism to keep up with the > new semantics, we will need the reverse operation of take_page_off_buddy(). > Do you think that that part will come with a separate work? Well, I am not really sure. Since we grab a refcount in page_handle_poison, all unpoison mechanism does is a "put_page", that should send the page back to buddy/pcp lists. I did not spot any problem when testing it, but I will double check. Thanks Naoya. -- Oscar Salvador SUSE L3