From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 509C6CA9EB9 for ; Tue, 22 Oct 2019 16:19:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32C822084B for ; Tue, 22 Oct 2019 16:19:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731589AbfJVQTY (ORCPT ); Tue, 22 Oct 2019 12:19:24 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:44116 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730331AbfJVQTY (ORCPT ); Tue, 22 Oct 2019 12:19:24 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 773C2FB03; Tue, 22 Oct 2019 18:19:21 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id asa4HXtqqs4k; Tue, 22 Oct 2019 18:19:20 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id B351E49BFE; Tue, 22 Oct 2019 18:19:19 +0200 (CEST) Date: Tue, 22 Oct 2019 18:19:19 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Daniel Baluta Cc: shawnguo@kernel.org, devicetree@vger.kernel.org, baruch@tkos.co.il, abel.vesa@nxp.com, Anson.Huang@nxp.com, ccaione@baylibre.com, andrew.smirnov@gmail.com, s.hauer@pengutronix.de, angus@akkea.ca, linux-kernel@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com, shengjiu.wang@nxp.com, linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de Subject: Re: [PATCH v4] arm64: dts: imx8mq: Init rates and parents configs for clocks Message-ID: <20191022161919.GA3727@bogon.m.sigxcpu.org> References: <20190728152040.15323-1-daniel.baluta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190728152040.15323-1-daniel.baluta@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sun, Jul 28, 2019 at 06:20:40PM +0300, Daniel Baluta wrote: > From: Abel Vesa > > Add the initial configuration for clocks that need default parent and rate > setting. This is based on the vendor tree clock provider parents and rates > configuration except this is doing the setup in dts rather then using clock > consumer API in a clock provider driver. > > Note that by adding the initial rate setting for audio_pll1/audio_pll > setting we need to remove it from imx8mq-librem5-devkit.dts It seems this never made it into any tree, any particular reason for that? Cheers, -- Guido > > Signed-off-by: Abel Vesa > Signed-off-by: Daniel Baluta > Tested-by: Angus Ainslie (Purism) > --- > Changes since v3: > - fix extra new lines > > .../dts/freescale/imx8mq-librem5-devkit.dts | 5 ----- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 19 +++++++++++++++++++ > 2 files changed, 19 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > index 683a11035643..c702ccc82867 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > @@ -169,11 +169,6 @@ > }; > }; > > -&clk { > - assigned-clocks = <&clk IMX8MQ_AUDIO_PLL1>, <&clk IMX8MQ_AUDIO_PLL2>; > - assigned-clock-rates = <786432000>, <722534400>; > -}; > - > &dphy { > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 02fbd0625318..a55d72ba2e05 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -494,6 +494,25 @@ > clock-names = "ckil", "osc_25m", "osc_27m", > "clk_ext1", "clk_ext2", > "clk_ext3", "clk_ext4"; > + assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1>, > + <&clk IMX8MQ_AUDIO_PLL1>, > + <&clk IMX8MQ_AUDIO_PLL2>, > + <&clk IMX8MQ_CLK_AHB>, > + <&clk IMX8MQ_CLK_NAND_USDHC_BUS>, > + <&clk IMX8MQ_CLK_AUDIO_AHB>, > + <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>, > + <&clk IMX8MQ_CLK_NOC>; > + assigned-clock-parents = <0>, > + <0>, > + <0>, > + <&clk IMX8MQ_SYS1_PLL_133M>, > + <&clk IMX8MQ_SYS1_PLL_266M>, > + <&clk IMX8MQ_SYS2_PLL_500M>, > + <&clk IMX8MQ_CLK_27M>, > + <&clk IMX8MQ_SYS1_PLL_800M>; > + assigned-clock-rates = <593999999>, > + <786432000>, > + <722534400>; > }; > > src: reset-controller@30390000 { > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >